Fix custom function handling in sympy solve visitor #1563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running NMODL with NEURON codegen on this file:
https://github.com/neuronsimulator/reduced_dentate/blob/master/mechanisms/tca.mod
we get the following kind of error, but the codegen proceeds:
The problem is that functions defined in mod files are not known to the code generator, so it's complaining it cannot do the codegen for them. A somewhat minimal example of this is the following mod file: