Fix race condition in CMake code. #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The race is cause by the fact that two targets exist to copy the Python
files. The first one because of `cpp_cc_build_time_copy` with
`NO_TARGET`. The second because of the:
add_custom_target(nmodl_copy_python_files ALL DEPENDS ...)
The solution is to not create the per file target by passing
`NO_TARGET` to `cpp_cc_build_time_copy`.
|
I suspect this has been the cause for the very infrequent build failure I see when using |
alkino
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race is cause by the fact that two targets exist to copy the Python files. The first one because of
cpp_cc_build_time_copywithoutNO_TARGET. The second because of the:The solution is to not create the per file target by passing
NO_TARGETtocpp_cc_build_time_copy.