Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve run_test.sh to check against NRN. #1135

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jan 9, 2024

We can run run_test.sh with a special generated by nocmodl. This helps debug simulate.py itself, which is useful when things get very subtle.

@1uc
Copy link
Collaborator Author

1uc commented Jan 9, 2024

Merge after #1134.

@1uc
Copy link
Collaborator Author

1uc commented Jan 9, 2024

An example of when is this useful is:

INITIAL {
  x = 42
}

BREAKPOINT {
  x = c
}

and now the question is should x[0] == 42.0 or x[0] == c? This is risky to answer without checking against NRN + nocmodl.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e520d76) 88.31% compared to head (8b1557e) 88.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1135   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files         175      175           
  Lines       12983    12983           
=======================================
  Hits        11466    11466           
  Misses       1517     1517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/crosscheck-with-nocmodl branch from 3c5d7e8 to 8b1557e Compare January 10, 2024 09:48
@1uc 1uc marked this pull request as ready for review January 10, 2024 09:54
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #184572 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit 369dff8 into master Jan 11, 2024
20 checks passed
@1uc 1uc deleted the 1uc/crosscheck-with-nocmodl branch January 11, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants