Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade spdlog and fmt #1132

Merged
merged 2 commits into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .sanitizers/undefined.supp
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
implicit-integer-sign-change:double vector[2] Eigen::internal::pabs<double vector[2]>(double vector[2] const&)
unsigned-integer-overflow:std::mersenne_twister_engine
unsigned-integer-overflow:fmt::v9::detail::make_write_int_arg
unsigned-integer-overflow:fmt::v10::detail::make_write_int_arg
5 changes: 3 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,12 @@ cpp_cc_git_submodule(pybind11 BUILD PACKAGE pybind11 REQUIRED)
# Tell spdlog not to use its bundled fmt, it should either use the fmt submodule or a truly external
# installation for consistency. This line should be harmless if we use an external spdlog.
set(SPDLOG_FMT_EXTERNAL ON)
cpp_cc_git_submodule(spdlog BUILD PACKAGE spdlog REQUIRED)
set(SPDLOG_SYSTEM_INCLUDE ON)
if(NMODL_3RDPARTY_USE_SPDLOG)
# See above, same logic as fmt
set_property(TARGET spdlog PROPERTY POSITION_INDEPENDENT_CODE ON)
set(SPDLOG_BUILD_PIC ON)
endif()
cpp_cc_git_submodule(spdlog BUILD PACKAGE spdlog REQUIRED)

# =============================================================================
# Format & execute ipynb notebooks in place (pip install nbconvert clean-ipynb)
Expand Down
2 changes: 1 addition & 1 deletion ext/fmt
Submodule fmt updated 80 files
+8 −0 .github/dependabot.yml
+3 −2 .github/pull_request_template.md
+30 −0 .github/workflows/cifuzz.yml
+9 −1 .github/workflows/doc.yml
+26 −0 .github/workflows/lint.yml
+30 −13 .github/workflows/linux.yml
+17 −2 .github/workflows/macos.yml
+65 −0 .github/workflows/scorecard.yml
+12 −4 .github/workflows/windows.yml
+13 −26 .gitignore
+113 −47 CMakeLists.txt
+5,533 −0 ChangeLog.md
+0 −5,255 ChangeLog.rst
+1 −1 LICENSE
+490 −0 README.md
+0 −531 README.rst
+6 −6 doc/_static/bootstrap.min.js
+251 −189 doc/api.rst
+11 −7 doc/build.py
+145 −12 doc/syntax.rst
+38 −0 doc/usage.rst
+7 −6 include/fmt/args.h
+584 −413 include/fmt/chrono.h
+62 −70 include/fmt/color.h
+35 −111 include/fmt/compile.h
+797 −1,151 include/fmt/core.h
+161 −206 include/fmt/format-inl.h
+1,260 −942 include/fmt/format.h
+67 −90 include/fmt/os.h
+77 −69 include/fmt/ostream.h
+210 −175 include/fmt/printf.h
+172 −156 include/fmt/ranges.h
+418 −52 include/fmt/std.h
+68 −38 include/fmt/xchar.h
+39 −30 src/fmt.cc
+1 −5 src/format.cc
+103 −62 src/os.cc
+1 −1 support/AndroidManifest.xml
+3 −3 support/Vagrantfile
+0 −1 support/bazel/.bazelrc
+1 −1 support/bazel/.bazelversion
+2 −2 support/bazel/BUILD.bazel
+5 −4 support/bazel/README.md
+1 −1 support/build.gradle
+0 −54 support/cmake/cxx14.cmake
+45 −19 support/manage.py
+0 −159 support/rst2md.py
+21 −4 test/CMakeLists.txt
+1 −1 test/add-subdirectory-test/CMakeLists.txt
+1 −1 test/args-test.cc
+532 −176 test/chrono-test.cc
+2 −2 test/compile-error-test/CMakeLists.txt
+1 −0 test/compile-fp-test.cc
+28 −43 test/compile-test.cc
+119 −239 test/core-test.cc
+2 −0 test/enforce-checks-test.cc
+1 −1 test/find-package-test/CMakeLists.txt
+28 −99 test/format-impl-test.cc
+728 −744 test/format-test.cc
+1 −1 test/fuzzing/CMakeLists.txt
+3 −1 test/gtest-extra-test.cc
+2 −2 test/gtest-extra.cc
+2 −7 test/gtest-extra.h
+1 −7 test/gtest/CMakeLists.txt
+2 −2 test/gtest/gmock-gtest-all.cc
+2 −2 test/mock-allocator.h
+36 −88 test/module-test.cc
+15 −56 test/os-test.cc
+34 −48 test/ostream-test.cc
+1 −7 test/posix-mock-test.cc
+4 −6 test/posix-mock.h
+15 −39 test/printf-test.cc
+198 −62 test/ranges-test.cc
+103 −31 test/scan-test.cc
+560 −135 test/scan.h
+1 −1 test/static-export-test/CMakeLists.txt
+247 −20 test/std-test.cc
+6 −2 test/util.cc
+15 −17 test/util.h
+187 −79 test/xchar-test.cc
2 changes: 1 addition & 1 deletion ext/spdlog
Submodule spdlog updated 103 files
Loading