Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve simple ODE. #1119

Merged
merged 15 commits into from
Dec 13, 2023
Merged

Solve simple ODE. #1119

merged 15 commits into from
Dec 13, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 8, 2023

Implements the functionality required to use NEURON as an ODE solver for the state x.

@1uc
Copy link
Collaborator Author

1uc commented Dec 8, 2023

Missing tests.

@bbpbuildbot

This comment has been minimized.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (916c695) 88.23% compared to head (c5f3b9a) 88.31%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 77.22% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
+ Coverage   88.23%   88.31%   +0.07%     
==========================================
  Files         175      175              
  Lines       12956    12979      +23     
==========================================
+ Hits        11432    11462      +30     
+ Misses       1524     1517       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/leonhard branch 2 times, most recently from 2003731 to ebf164f Compare December 11, 2023 13:22
@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/leonhard branch 2 times, most recently from 62ee1d2 to feb4eac Compare December 11, 2023 13:59
@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review December 11, 2023 15:11
@bbpbuildbot

This comment has been minimized.

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor comments otherwise looks ok.

src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
test/unit/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
test/usecases/run_test.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@iomaganaris iomaganaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and welcome changes 👍 Few suggestions here and there

CMakeLists.txt Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
test/usecases/leonhard/simulate.py Outdated Show resolved Hide resolved
@1uc
Copy link
Collaborator Author

1uc commented Dec 12, 2023

@pramodk @iomaganaris IFAICT this should address all concerns.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #179869 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris merged commit 0f93719 into master Dec 13, 2023
20 checks passed
@iomaganaris iomaganaris deleted the 1uc/leonhard branch December 13, 2023 11:03
@iomaganaris iomaganaris added the NEURON codegen Work toward NEURON code generation label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEURON codegen Work toward NEURON code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants