Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compute_method_name to CodegenCppVisitor. #1114

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 7, 2023

No description provided.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7265ec9) 88.23% compared to head (b36d811) 88.24%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_cpp_visitor.cpp 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   88.23%   88.24%           
=======================================
  Files         175      175           
  Lines       12951    12960    +9     
=======================================
+ Hits        11427    11436    +9     
  Misses       1524     1524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review December 8, 2023 08:47
@1uc 1uc merged commit b6801af into master Dec 8, 2023
18 checks passed
@1uc 1uc deleted the 1uc/move-compute_method_name branch December 8, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants