Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements in CodegenCppVisitor constructors #1079

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

iomaganaris
Copy link
Contributor

  • There is no purpose of having private constructors any more
  • No reason for anything related to wrappers
  • Remove mention of C code in logs

Copy link
Member

@tristan0x tristan0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code !!! Very cool!

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (f180a2d) 70.19% compared to head (88c0ea3) 70.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
- Coverage   70.19%   70.18%   -0.01%     
==========================================
  Files         188      188              
  Lines       25630    25627       -3     
==========================================
- Hits        17990    17987       -3     
  Misses       7640     7640              
Files Changed Coverage Δ
src/codegen/codegen_cpp_visitor.cpp 85.54% <ø> (-0.02%) ⬇️
src/codegen/codegen_cpp_visitor.hpp 100.00% <100.00%> (ø)
src/main.cpp 71.23% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #155527 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris merged commit bb20e8b into master Sep 25, 2023
16 checks passed
@iomaganaris iomaganaris deleted the magkanar/simplify_codegen_constructors branch September 25, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants