Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbor cable cell exporter and backend #393
Arbor cable cell exporter and backend #393
Changes from 7 commits
3d9e7fa
fc52a06
3e20642
dbf766f
fba5376
8bd6539
d2f2f42
22ad6da
2228979
760f53c
315457c
dccc375
f72690d
e88168f
c0af192
27827fb
de52dea
08c9157
152033e
f2ca1ed
2c67258
ab004f6
0a8a932
e685990
26f3af1
a7453f8
79dda2e
fac077d
6aa15de
cde9b96
6d76ed1
3978d31
5d4ad03
d98041d
c425101
9443b12
d958c14
f2d93e3
4bc6424
e83dbc0
ebd32d0
9bbc68e
bcada48
b973162
9dd09e6
4148974
73772ea
e85d695
93c0685
02a00fb
04ce614
5c9a5bf
70fddf8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add support for myelinated in Arbor? Do you know how these section are defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely sure where this is used (it doesn't seem to be in
l5pc
). A quick search finds it in several.hoc
files inexamples/stochkv
. Does somebody else have insights on this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'myelinated' is a sectionlist we're using in our latest models. It's a cylinder attached to the end of the AIS to prevent boundary effects. It doesn't have channels but just represent a myelinated chunk of axon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wvangeit for the explanation. I assume AIS means axon initial segment. Is there an example/morphology with
myelinated
? Otherwise, I'd suggest to throw an exception for now until we can properly test that in Arbor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have this in open source models yet. But it's fairly simple code though. It's not specified in the morphology file itself, but used in the replace_axon function when constructing the model:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - it works with your code above added to
replace_axon
. I've added the necessary changes to c0af192, but they're currently commented out as I have no way to figure out if themyelin
section exists without crashing in Neuron.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, but i wonder if hasattr():
https://www.w3schools.com/python/ref_func_hasattr.asp
would work on icell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works on myelin and the
len(self.icell.myelin) == 1
looks like a bug given that NEURON crashes, complaining that the section was deleted upon accessing e.g.self.icell.myelin[0]
. I've added safe support formyelin
now in 2c67258.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's look at this in a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #419.