Change channel/synth configuration methods #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arduano
reviewed
Aug 18, 2024
core/src/channel_group/mod.rs
Outdated
| config.audio_params, | ||
| channel_pool.clone(), | ||
| )); | ||
| channel_events_cache.push(Vec::new()); | ||
| sample_cache_vecs.push(Vec::new()); | ||
| } | ||
|
|
||
| if config.channel_count >= 16 { |
There was a problem hiding this comment.
Just for later, but should we make this optional in the future? Just a config flag or something if it's not too messy
There was a problem hiding this comment.
I mean we could, although the user always will have the option to send a config event to channel 10 to make it standard if they wish.
One idea would also be to manage the channel count with a type or something
enum SynthFormat {
// Will create 16 channels, with 10 being drums
Midi,
// Probably other formats here? Idk what else there is
// Will create the amount of channels without setting any to drums
// so the user can do it themselves
Custom { channels: u32 }.
}
arduano
approved these changes
Aug 20, 2024
arduano
approved these changes
Aug 21, 2024
Kaydax
pushed a commit
that referenced
this pull request
Aug 21, 2024
MyBlackMIDIScore
added a commit
that referenced
this pull request
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChannelConfigEventSynthEventto useChannelEventinstead of audio of config so it is a bit more verbose and configurableI haven't benchmarked this yet