Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to piano when an instrument is not found #74

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

arduano
Copy link
Collaborator

@arduano arduano commented Dec 9, 2023

After iterating through all soundfonts for the preset/bank, it will also attempt to try 0/0 preset/bank, before resorting to no spawner at all.

Fixes #72

@arduano
Copy link
Collaborator Author

arduano commented Dec 9, 2023

@MyBlackMIDIScore gonna merge this because it fixes the issue a user is having, but lmn if it looks right, I'm not 100% sure what the logic in other synths for this is

@arduano arduano merged commit c584957 into master Dec 9, 2023
1 check passed
@arduano arduano deleted the piano-fallback-on-instruments branch December 9, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some midis have few inaudible notes or are completely mute
1 participant