Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): support whale test suite for defid ocean #2174

Closed
wants to merge 29 commits into from

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Dec 1, 2023

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Allow ocean test-suites running on Defid
Its tricky to map Defid Ocean API and function with Whale Ocean
eg:

if (app instanceof DefidBin) {
      controller = app.addressController
} else {
      controller = app.get(AddressController)
}

Sinonjs-like is an ideal approach

Additional comments?:

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 1819b10
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/65b23b3be5c2d50008b7a7fd
😎 Deploy Preview https://deploy-preview-2174--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@canonbrother canonbrother changed the title chore(): support whale test suite with defid ocean chore(): support whale test suite at defid ocean Dec 1, 2023
@canonbrother canonbrother changed the title chore(): support whale test suite at defid ocean chore(): support whale test suite for defid ocean Dec 1, 2023
@canonbrother canonbrother force-pushed the canonbrother/defid-ocean branch 2 times, most recently from 666ea64 to 486d168 Compare December 11, 2023 09:56
@canonbrother canonbrother force-pushed the canonbrother/defid-ocean branch from 486d168 to 8115a1e Compare December 11, 2023 10:31
@canonbrother canonbrother force-pushed the canonbrother/defid-ocean branch from 1454ea5 to 411fe85 Compare December 13, 2023 09:01
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 289 lines in your changes are missing coverage. Please review.

Comparison is base (e04c2b0) 91.84% compared to head (1819b10) 65.27%.

Files Patch % Lines
apps/whale-api/src/e2e.defid.module.ts 8.41% 257 Missing and 26 partials ⚠️
apps/whale-api/src/e2e.module.ts 62.50% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2174       +/-   ##
===========================================
- Coverage   91.84%   65.27%   -26.57%     
===========================================
  Files         374      357       -17     
  Lines       11301    11360       +59     
  Branches     1477     1527       +50     
===========================================
- Hits        10379     7415     -2964     
- Misses        891     3713     +2822     
- Partials       31      232      +201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2024

Docker build preview for jellyfish/apps is ready!

Built with commit 820dc27

  • ghcr.io/birthdayresearch/legacy-api:pr-2174
  • ghcr.io/birthdayresearch/playground-api:pr-2174
  • ghcr.io/birthdayresearch/status-api:pr-2174
  • ghcr.io/birthdayresearch/whale-api:pr-2174

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:820dc27b1b89c7db49bc1dff4c709dd9aa3230c9
  • ghcr.io/birthdayresearch/playground-api:820dc27b1b89c7db49bc1dff4c709dd9aa3230c9
  • ghcr.io/birthdayresearch/status-api:820dc27b1b89c7db49bc1dff4c709dd9aa3230c9
  • ghcr.io/birthdayresearch/whale-api:820dc27b1b89c7db49bc1dff4c709dd9aa3230c9

@canonbrother canonbrother self-assigned this Jan 3, 2024
@canonbrother canonbrother force-pushed the canonbrother/defid-ocean branch from 08021b8 to e17804e Compare January 25, 2024 09:42
@canonbrother canonbrother force-pushed the canonbrother/defid-ocean branch from 0b40e44 to 1819b10 Compare January 25, 2024 10:43
@canonbrother
Copy link
Contributor Author

refer to #2177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant