fix listProposalVotes

BirthdayResearch · Jan 3, 2024 · e593410 · e593410
1 parent 7c17c0a
commit e593410
Showing 1 changed file with 10 additions and 15 deletions.
diff --git a/apps/whale-api/src/e2e.defid.module.ts b/apps/whale-api/src/e2e.defid.module.ts
@@ -165,22 +165,17 @@ export class DGovernanceController extends DefidOceanController {
     return await this.api.get(`/governance/proposals/${id}`)
   }
 
-  async listProposalVotes (id: string, query: OceanProposalQuery): Promise<ApiPagedResponse<ProposalVotesResult>> {
-    const q: OceanProposalQuery = {
-      masternode: MasternodeType.MINE,
-      cycle: 0,
-      all: false,
-      query: {
-        size: 30,
-        next: undefined
-      },
-      ...query
-    }
-    const qStr = `masternode=${q.masternode}&cycle=${q.cycle}&all=${q.all}&size=${q.query?.size}`
-    if (q?.query?.next !== undefined) {
-      return await this.api.get(`/governance/proposals/${id}/votes?${qStr}&next=${q.query.next}`)
+  async listProposalVotes (
+    id: string,
+    masternode = MasternodeType.MINE,
+    cycle = 0,
+    all = false,
+    query: OceanListQuery = { size: 30 }
+  ): Promise<ApiPagedResponse<ProposalVotesResult>> {
+    if (query.next !== undefined) {
+      return await this.api.get(`/governance/proposals/${id}/votes?masternode=${masternode}&cycle=${cycle}&all=${all}&size=${query.size}&next=${query.next}`)
     }
-    return await this.api.get(`/governance/proposals/${id}/votes?${qStr}`)
+    return await this.api.get(`/governance/proposals/${id}/votes?masternode=${masternode}&cycle=${cycle}&all=${all}&size=${query.size}`)
   }
 }