updated npm deps, mono-repo can't be auto updated (#464)

removed redundant gitignore in .husky
added missing jellyfish-wallet-classic setup
updated CODEOWNERS
updated CONTRIBUTING.md
updated .github/workflows
updated governance workflow

.github/CODEOWNERS

@@ -13,22 +13,22 @@
 /packages/jellyfish-api-core/                               @fuxingloh @canonbrother @jingyi2811 @thedoublejay @ivan-zynesis @siradji @aikchun
 /packages/jellyfish-api-core/src/category/icxorderbook.ts   @fuxingloh @surangap @monstrobishi @canonbrother
 /packages/jellyfish-api-core/src/category/oracle.ts         @fuxingloh @jingyi2811 @surangap @canonbrother @monstrobishi
+/packages/jellyfish-api-core/src/category/proposal.ts       @fuxingloh @surangap @Jouzo
 
 /packages/jellyfish-api-jsonrpc/                @fuxingloh @thedoublejay
 /packages/jellyfish-crypto/                     @fuxingloh @ivan-zynesis
 /packages/jellyfish-json/                       @fuxingloh @canonbrother
 /packages/jellyfish-network/                    @fuxingloh @ivan-zynesis
 
-/packages/jellyfish-transaction/                            @fuxingloh @ivan-zynesis
+/packages/jellyfish-transaction/                            @fuxingloh @ivan-zynesis @canonbrother
 /packages/jellyfish-transaction/src/script/                 @fuxingloh @canonbrother @ivan-zynesis @jingyi2811
-/packages/jellyfish-transaction/src/script/buffer/          @fuxingloh @canonbrother @ivan-zynesis
-/packages/jellyfish-transaction/src/script/defi/            @fuxingloh @canonbrother @ivan-zynesis @monstrobishi
+/packages/jellyfish-transaction/src/script/dftx/            @fuxingloh @canonbrother @ivan-zynesis @monstrobishi
 
 /packages/jellyfish-transaction-builder/        @fuxingloh @ivan-zynesis @monstrobishi
 /packages/jellyfish-transaction-signature/      @fuxingloh @ivan-zynesis
 /packages/jellyfish-wallet/                     @fuxingloh @ivan-zynesis @monstrobishi
-/packages/jellyfish-wallet-mnemonic/            @fuxingloh @ivan-zynesis
 /packages/jellyfish-wallet-classic/             @fuxingloh @ivan-zynesis @monstrobishi
+/packages/jellyfish-wallet-mnemonic/            @fuxingloh @ivan-zynesis
 /packages/testcontainers/                       @fuxingloh
 /packages/testing/                              @fuxingloh @canonbrother
 

.github/dependabot.yml

@@ -11,9 +11,18 @@ updates:
       - dependency-name: "@parcel/*"
       - dependency-name: "@defichain/*"
 
+  - package-ecosystem: 'npm'
+    directory: '/website'
+    schedule:
+      interval: 'weekly'
+    labels:
+      - "kind/dependencies"
+    ignore:
+      - dependency-name: "@defichain/*"
+
   - package-ecosystem: "github-actions"
     directory: "/"
     schedule:
       interval: "daily"
     labels:
-      - "kind/chore"
+      - "kind/dependencies"

.github/governance.yml

@@ -20,6 +20,11 @@ issue:
         - feature
         - bug
         - question
+        - fix
+        - chore
+        - docs
+        - refactor
+        - dependencies
       multiple: false
       needs: true
       author_association:
@@ -44,6 +49,7 @@ issue:
         - jellyfish-transaction-builder
         - jellyfish-transaction-signature
         - jellyfish-wallet
+        - jellyfish-wallet-classic
         - jellyfish-wallet-mnemonic
         - testcontainers
         - testing

.github/labeler.yml

@@ -61,6 +61,11 @@ labels:
     matcher:
       files: "packages/jellyfish-transaction-signature/**"
 
+  - label: area/jellyfish-wallet-classic
+    sync: true
+    matcher:
+      files: "packages/jellyfish-wallet-classic/**"
+
   - label: area/jellyfish-wallet-mnemonic
     sync: true
     matcher:

.github/labels.yml

@@ -78,6 +78,8 @@
   name: area/jellyfish-transaction-signature
 - color: fbca04
   name: area/jellyfish-wallet
+- color: fbca04
+  name: area/jellyfish-wallet-classic
 - color: fbca04
   name: area/jellyfish-wallet-mnemonic
 - color: fbca04

.github/release-drafter.yml

@@ -22,7 +22,7 @@ version-resolver:
     labels:
       - 'kind/feature'
   default: patch
-prerelease: true
+prerelease: false
 template: |
   ## What’s Changed
 

.github/workflows/oss-governance-labeler.yml

@@ -2,7 +2,6 @@ name: Governance
 
 on:
   pull_request_target:
-    branches: [ master, main ]
     types: [ synchronize, opened ]
 
 jobs:

.github/workflows/oss-governance-project-issue.yml

@@ -2,24 +2,15 @@ name: Governance Issues
 
 on:
   issues:
-    types: [ opened, labeled, unlabeled ]
+    types: [ opened, labeled ]
 
 jobs:
   main:
     name: DeFi Products
     runs-on: ubuntu-latest
-    if: contains(github.event.issue.labels.*.name, 'triage/accepted')
+    if: contains(github.event.issue.labels.*.name, 'triage/accepted') && github.event.issue.state == 'open'
     steps:
       - uses: peter-evans/create-or-update-project-card@c75ba6ac3c7c432dedd22a553951c216a4664b5f
-        if: contains(github.event.issue.labels.*.name, 'priority/urgent-now') || contains(github.event.issue.labels.*.name, 'priority/important-soon')
-        with:
-          token: ${{ secrets.DEFICHAIN_BOT_GITHUB_TOKEN }}
-          project-location: defich
-          project-name: DeFi Products
-          column-name: Prioritized
-
-      - uses: peter-evans/create-or-update-project-card@c75ba6ac3c7c432dedd22a553951c216a4664b5f
-        if: "!contains(github.event.issue.labels.*.name, 'priority/urgent-now') && !contains(github.event.issue.labels.*.name, 'priority/important-soon')"
         with:
           token: ${{ secrets.DEFICHAIN_BOT_GITHUB_TOKEN }}
           project-location: defich

.github/workflows/sync-labels.yml

@@ -12,8 +12,8 @@ jobs:
     steps:
       - uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
 
-      - uses: micnncim/action-label-syncer@0e9c5104859d0e78219af63791636eba42382b5d
+      - uses: micnncim/action-label-syncer@3abd5ab72fda571e69fffd97bd4e0033dd5f495c
         with:
-          prune: false
+          prune: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

CONTRIBUTING.md

@@ -4,6 +4,14 @@
 
 Each package or functionality must be accompanied by full coverage testing.
 
+Due to Javascript type coercion, all test assertions must use strict equality checking.
+
+```diff
+-   expect(1).toBe('1')
+-   expect(1).toEqual('1')
++   expect(1).toStrictEqual(1)
+```
+
 ## TODO comments
 
 TODO comments should usually include the author's github username in parentheses. Example:
@@ -45,3 +53,14 @@ Example: Use `foo_bar.ts` instead of `foo-bar.ts`.
 ### Use JSDoc for exported symbols.
 
 ### Top level functions should not use arrow syntax.
+
+### `constants.ts` not allowed
+
+It's an anti-pattern for scaling code, it gives a false impression of separation of concern. All it does is create a
+mass of code concentration within project that were better separated.
+
+> An analogy for this problem is file organization in projects. Many of us have come to agree that organizing files by
+> file type (e.g. splitting everything into html, js and css folders) don't really scale. The code related to a feature
+> will be forced to be split between three folders, just for a false impression of "separation of concerns". The key
+> here is that "concerns" is not defined by file type. Instead, most of us opt to organize files by feature or
+> responsibility. https://github.com/vuejs/rfcs/issues/55#issuecomment-504875870

README.md

@@ -87,6 +87,7 @@ Package                                            | Description
 `@defichain/jellyfish-network`                     | Contains DeFi blockchain various network configuration for mainnet, testnet and regtest.
 `@defichain/jellyfish-transaction`                 | Dead simple modern stateless raw transaction composer for the DeFi Blockchain.
 `@defichain/jellyfish-transaction-builder`         | Provides a high-high level abstraction for constructing transaction ready to be broadcast for DeFi Blockchain.
+`@defichain/jellyfish-wallet-classic`              | WalletClassic implements a simple, single elliptic pair wallet.
 `@defichain/jellyfish-wallet`                      | Jellyfish wallet is a managed wallet, where account can get discovered from an HD seed.
 `@defichain/jellyfish-wallet-mnemonic`             | MnemonicHdNode implements the WalletHdNode from jellyfish-wallet; a CoinType-agnostic HD Wallet for noncustodial DeFi.
 `@defichain/testcontainers`                        | Provides a lightweight, throw away instances for DeFiD node provisioned automatically in a Docker container.

jest.config.js

@@ -11,8 +11,8 @@ module.exports = {
     '@defichain/jellyfish-transaction-signature': '<rootDir>/packages/jellyfish-transaction-signature/src',
     '@defichain/jellyfish-transaction-builder': '<rootDir>/packages/jellyfish-transaction-builder/src',
     '@defichain/jellyfish-transaction': '<rootDir>/packages/jellyfish-transaction/src',
-    '@defichain/jellyfish-wallet-mnemonic': '<rootDir>/packages/jellyfish-wallet-mnemonic/src',
     '@defichain/jellyfish-wallet-classic': '<rootDir>/packages/jellyfish-wallet-classic/src',
+    '@defichain/jellyfish-wallet-mnemonic': '<rootDir>/packages/jellyfish-wallet-mnemonic/src',
     '@defichain/jellyfish-wallet': '<rootDir>/packages/jellyfish-wallet/src',
     '@defichain/testcontainers': '<rootDir>/packages/testcontainers/src',
     '@defichain/testing': '<rootDir>/packages/testing/src'