Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zhCN.lua #43

Merged
merged 3 commits into from
Jan 1, 2024
Merged

Update zhCN.lua #43

merged 3 commits into from
Jan 1, 2024

Conversation

nanjuekaien1
Copy link
Contributor

No description provided.

@funkydude
Copy link
Member

Please don't take "creative liberty" with translations. I appreciate that you have a suggestion to improve it, but you should do that by making a GitHub report, or by suggesting it on our DIscord, or direct message me on Discord.

I changed the translation for the chat message L.detect_magic_warning to add color like you wanted, and also to turn it into a clickable spell link.
But the translation for L.detect_magic_missing is a BigWigs message, so it shouldn't be changed.

@nanjuekaien1
Copy link
Contributor Author

nanjuekaien1 commented Jan 1, 2024

ok
Is it okay to add the striking symbols when translating? For example: > remind <; 『remind 』.

@funkydude funkydude merged commit 1d26b69 into BigWigsMods:master Jan 1, 2024
1 check passed
@funkydude
Copy link
Member

Only if it's in the original translation, like a "quote"

@nanjuekaien1
Copy link
Contributor Author

ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants