Optimize JobWrapper queueing ActiveJobs

lib/delayed/active_job_adapter.rb

@@ -14,7 +14,7 @@ def _enqueue(job, opts = {})
       opts.merge!({ queue: job.queue_name, priority: job.priority }.compact)
         .merge!(job.provider_attributes || {})
 
-      Delayed::Job.enqueue(JobWrapper.new(job.serialize), opts).tap do |dj|
+      Delayed::Job.enqueue(JobWrapper.new(job), opts).tap do |dj|
         job.provider_job_id = dj.id
       end
     end

lib/delayed/job_wrapper.rb

@@ -4,8 +4,16 @@ class JobWrapper # rubocop:disable Betterment/ActiveJobPerformable
 
     delegate_missing_to :job
 
-    def initialize(job_data)
-      @job_data = job_data
+    def initialize(job_or_data)
+      # During enqueue the job instance is passed in directly, saves us deserializing
+      # it to find out how to queue the job.
+      # During load from the db, we get a data hash passed in so deserialize lazily.
+      if job_or_data.is_a?(ActiveJob::Base)
+        @job = job_or_data
+        @job_data = job.serialize
+      else
+        @job_data = job_or_data
+      end
     end
 
     def display_name
@@ -25,7 +33,9 @@ def encode_with(coder)
     private
 
     def job
-      @job ||= ActiveJob::Base.deserialize(job_data) if job_data
+      return @job if defined?(@job)
+
+      @job = ActiveJob::Base.deserialize(job_data) if job_data
     end
   end
 end

spec/delayed/active_job_adapter_spec.rb

@@ -23,6 +23,16 @@ def perform; end
     ActiveJob::Base.queue_adapter = adapter_was
   end
 
+  it "does not invoke #deserialize during enqueue" do # rubocop:disable RSpec/NoExpectationExample
+    JobClass.include(Module.new do
+      def deserialize(*)
+        raise "uh oh, deserialize called during enqueue!"
+      end
+    end)
+
+    JobClass.perform_later
+  end
+
   it 'serializes a JobWrapper in the handler with expected fields' do
     Timecop.freeze('2023-01-20T18:52:29Z') do
       JobClass.perform_later