modify tests to not raise deprecation warnings #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07pepa
force-pushed
the
remove-deprecated-stuff
branch
from
9b72a6c to
743c1c8
Compare
07pepa
commented
Oct 10, 2024
| @@ -1136,7 +1136,7 @@ async def inspect_collection( | |||
| return inspection_result | |||
|
|
|||
| @classmethod | |||
| def check_hidden_fields(cls): | |||
There was a problem hiding this comment.
imho this should not be public method
07pepa
commented
Oct 10, 2024
| @@ -197,118 +297,38 @@ async def session(cli): | |||
| await s.end_session() | |||
|
|
|||
|
|
|||
| @pytest.fixture() | |||
| async def deprecated_init_beanie(db): | |||
There was a problem hiding this comment.
i wanted to explicitly separate deprecated usages from not deprecated ones
i also added assertions those deprecations are actualy raised
07pepa
changed the title
07pepa
requested review from
staticxterm,
adeelsohailahmed,
LawMixer and
CAPITAINMARVEL
LawMixer
approved these changes
Oct 10, 2024
07pepa
force-pushed
the
remove-deprecated-stuff
branch
from
743c1c8 to
cc49c2a
Compare
staticxterm
approved these changes
Oct 12, 2024
| with warnings.catch_warnings(record=True) as w: | ||
| warnings.simplefilter("always") | ||
|
|
||
| await init_beanie( |
There was a problem hiding this comment.
Only one slight "issue" is that now init_beanie will be executed twice (but I guess this is fine), since there is an autouse init fixture in this file as well.
There was a problem hiding this comment.
yes geting rid of auto use would be hard.... i am fully aware of it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.