Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-commit #1046

Merged
merged 1 commit into from
Oct 11, 2024
Merged

update pre-commit #1046

merged 1 commit into from
Oct 11, 2024

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Oct 9, 2024

simple pr updating pre-commit

LawMixer
LawMixer previously approved these changes Oct 9, 2024
Copy link

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough

CAPITAINMARVEL
CAPITAINMARVEL previously approved these changes Oct 9, 2024
Copy link
Contributor

@CAPITAINMARVEL CAPITAINMARVEL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@CAPITAINMARVEL
Copy link
Contributor

beanie/odm/queries/find.py:1033:12: E721 Use is and is not for type comparisons, or isinstance() for isinstance checks

That would be in another PR I assume ?

@07pepa 07pepa dismissed stale reviews from CAPITAINMARVEL and LawMixer via 97250f9 October 9, 2024 20:35
* update files failing
@07pepa
Copy link
Member Author

07pepa commented Oct 9, 2024

beanie/odm/queries/find.py:1033:12: E721 Use is and is not for type comparisons, or isinstance() for isinstance checks

That would be in another PR I assume ?

it shoul be here but was missed

@07pepa 07pepa merged commit ef58386 into BeanieODM:main Oct 11, 2024
56 checks passed
@07pepa 07pepa deleted the bump-precommit branch October 11, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants