-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.7 #1044
Conversation
07pepa
commented
Oct 8, 2024
•
edited
Loading
edited
- modify gh actions
- improve dependency definitions
11ce590
to
e78a20a
Compare
12f32f8
to
019e97b
Compare
019e97b
to
b18761a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @07pepa, the PR is good. However, I believe that it may be better if we split it into multiple ones. Either that or somehow change the PR title to be more succinct and just generally rephrased.
The main point as I understand it is the deprecation of Python 3.7 and the changes to the CI machinery and in pyproject.toml. Then we have the uplifts of development dependencies, some codebase modernization due to deprecations and a single Pydantic v2 Config compatibility fix in the test models...
I feel like the intent may better be conveyed if we have at least 3 separate PRs for this. But this is just my opinion, curious what others think.
7def57d
to
a379041
Compare
yea this is kindy my bad habit of mine .... keeping only pyproject changes and ci cd changes |
a379041
to
de6d6f6
Compare
* modify GitHub actions * improve dependency definitions
de6d6f6
to
7273d95
Compare
Looks good, I mean there's again more than one change but that's fine I guess since it only impacts our development experience. |
I suggest we support 3.8 for a month or so, at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough PR
Looks goods
https://peps.python.org/pep-0593/ |