Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #1044

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Oct 8, 2024

  • modify gh actions
  • improve dependency definitions

@07pepa 07pepa force-pushed the remove-python-3.7 branch 8 times, most recently from 11ce590 to e78a20a Compare October 8, 2024 14:07
@07pepa 07pepa changed the title remove python 3.7 and improve dependency bump pre-commit remove python 3.7 / improve dependency /bump pre-commit Oct 8, 2024
@07pepa 07pepa force-pushed the remove-python-3.7 branch 2 times, most recently from 12f32f8 to 019e97b Compare October 8, 2024 15:06
@07pepa 07pepa changed the title remove python 3.7 / improve dependency /bump pre-commit remove python 3.7 / improve dependency / bump pre-commit / remove deprecated functions Oct 8, 2024
@07pepa 07pepa force-pushed the remove-python-3.7 branch from 019e97b to b18761a Compare October 8, 2024 15:16
Copy link
Contributor

@staticxterm staticxterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @07pepa, the PR is good. However, I believe that it may be better if we split it into multiple ones. Either that or somehow change the PR title to be more succinct and just generally rephrased.

The main point as I understand it is the deprecation of Python 3.7 and the changes to the CI machinery and in pyproject.toml. Then we have the uplifts of development dependencies, some codebase modernization due to deprecations and a single Pydantic v2 Config compatibility fix in the test models...

I feel like the intent may better be conveyed if we have at least 3 separate PRs for this. But this is just my opinion, curious what others think.

.github/workflows/github-actions-tests.yml Outdated Show resolved Hide resolved
@07pepa 07pepa force-pushed the remove-python-3.7 branch 2 times, most recently from 7def57d to a379041 Compare October 9, 2024 19:11
@07pepa
Copy link
Member Author

07pepa commented Oct 9, 2024

Hi @07pepa, the PR is good. However, I believe that it may be better if we split it into multiple ones. Either that or somehow change the PR title to be more succinct and just generally rephrased.

The main point as I understand it is the deprecation of Python 3.7 and the changes to the CI machinery and in pyproject.toml. Then we have the uplifts of development dependencies, some codebase modernization due to deprecations and a single Pydantic v2 Config compatibility fix in the test models...

I feel like the intent may better be conveyed if we have at least 3 separate PRs for this. But this is just my opinion, curious what others think.

yea this is kindy my bad habit of mine ....

keeping only pyproject changes and ci cd changes

@07pepa 07pepa force-pushed the remove-python-3.7 branch from a379041 to de6d6f6 Compare October 9, 2024 19:15
@07pepa 07pepa changed the title remove python 3.7 / improve dependency / bump pre-commit / remove deprecated functions remove python 3.7 Oct 9, 2024
* modify GitHub actions
* improve dependency definitions
@07pepa 07pepa force-pushed the remove-python-3.7 branch from de6d6f6 to 7273d95 Compare October 9, 2024 20:36
@staticxterm
Copy link
Contributor

Looks good, I mean there's again more than one change but that's fine I guess since it only impacts our development experience.
One last proposal though is to perhaps rename the PR title to 'Drop support for Python 3.7' or something along those lines since 'remove python' sounds a bit weird 😅
Next on our to do list of sorts should also be to see for how long we would want to support Py3.8 since it lost official support now as well...

@adeelsohailahmed
Copy link
Member

Next on our to do list of sorts should also be to see for how long we would want to support Py3.8 since it lost official support now as well...

I suggest we support 3.8 for a month or so, at least.

@07pepa 07pepa requested a review from staticxterm October 10, 2024 08:25
@07pepa 07pepa changed the title remove python 3.7 Drop support for Python 3.7 Oct 10, 2024
Copy link
Contributor

@CAPITAINMARVEL CAPITAINMARVEL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough PR
Looks goods

@CAPITAINMARVEL
Copy link
Contributor

CAPITAINMARVEL commented Oct 10, 2024

Next on our to do list of sorts should also be to see for how long we would want to support Py3.8 since it lost official support now as well...

I suggest we support 3.8 for a month or so, at least.

https://peps.python.org/pep-0593/
example Annotated for Indexed(
(if we drop 3.8)

@07pepa 07pepa merged commit cbf8a74 into BeanieODM:main Oct 11, 2024
51 checks passed
@07pepa 07pepa deleted the remove-python-3.7 branch October 11, 2024 07:21
07pepa added a commit to 07pepa/beanie that referenced this pull request Oct 11, 2024
07pepa added a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants