Skip to content

Commit

Permalink
all: update agp 8.7.3 and remove sonar
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasMengelatte committed Dec 6, 2024
1 parent 9a45633 commit 8f06062
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 60 deletions.
10 changes: 1 addition & 9 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ test-coverage:
./gradlew testDebugCoverageUnitTest && \
awk -F"," '{ instructions += $$4 + $$5; covered += $$5 } END { print covered, "/", instructions, "instructions covered"; print "Total", 100*covered/instructions "% covered" }' mixpanel-dispatcher/build/test-results/jacoco.csv

check-token:
ifndef SONAR_TOKEN
$(error SONAR_TOKEN is undefined)
endif

sonar: check-token
./gradlew sonarqube

lint:
./gradlew lintDebug

Expand All @@ -33,4 +25,4 @@ ci: clean lint test-coverage aar
publish: aar
./gradlew mixpanel-dispatcher:publish

.PHONY: ci sonar check-token
.PHONY: ci
7 changes: 3 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
buildscript {
repositories {
google()
jcenter()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.6.0'
classpath 'org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:2.8'
classpath 'com.android.tools.build:gradle:8.7.3'
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
Expand All @@ -16,8 +15,8 @@ buildscript {
allprojects {
repositories {
google()
jcenter()
mavenLocal()
mavenCentral()
}
}

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip
9 changes: 4 additions & 5 deletions mixpanel-dispatcher/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ ext {
}

android {
compileSdkVersion 30
namespace "com.batch.android.dispatcher.mixpanel"
compileSdk 35

defaultConfig {
minSdkVersion 15
targetSdkVersion 30
minSdkVersion 21
versionCode 2
versionName "2.0.0"

Expand Down Expand Up @@ -54,5 +54,4 @@ dependencies {
}

apply from: 'maven-publish.gradle'
apply from: 'jacoco.gradle'
apply from: 'sonar.gradle'
apply from: 'jacoco.gradle'
39 changes: 0 additions & 39 deletions mixpanel-dispatcher/sonar.gradle

This file was deleted.

3 changes: 1 addition & 2 deletions mixpanel-dispatcher/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<manifest package="com.batch.android.dispatcher.mixpanel"
xmlns:android="http://schemas.android.com/apk/res/android">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application>
<service
Expand Down

0 comments on commit 8f06062

Please sign in to comment.