Add support for generics in pagination macro #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar_rust_sdk_derive/src/lib.rs
Outdated
| let expanded = quote! { | ||
| impl Paginatable for #struct_name { | ||
| impl #impl_generics Paginatable for #struct_name #type_generics #where_clause { |
There was a problem hiding this comment.
Kunnen we het hier een keer over hebben? Ik zeg niet dat het fout is maar ik wil het wat beter begrijpen voordat ik het approve.
tluijken
approved these changes
Jul 11, 2024
kevin-pease
force-pushed
the
70-generics-for-pagination
branch
from
c99f7e0 to
e78c80e
Compare
kevin-pease
force-pushed
the
70-generics-for-pagination
branch
from
e78c80e to
01e254f
Compare
LeonardTibben
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Fixes #70. Modifies the pagination derive macro to account for generics in structs.
The compiler throws a cryptic and unhelpful error when trying to apply the pagination macro to a struct with generics. This is because the macro previously didn't handle generics.
🆕 What is the new behavior (if this is a feature change)?
Structs with generics can now also be used. Behaviour for structs without generics remain unchanged.
💥 Does this PR introduce a breaking change?
No.
📝 Links to relevant issues/docs
https://docs.rs/syn/latest/syn/struct.Generics.html
🤔 Checklist before submitting