'Post Transaction' endpoint #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tluijken
requested changes
Aug 22, 2024
tluijken
force-pushed
the
57-post-transaction-endpoint
branch
2 times, most recently
from
8456c6d to
1fbcde6
Compare
tluijken
force-pushed
the
57-post-transaction-endpoint
branch
from
1fbcde6 to
3b2582d
Compare
tluijken
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Fixes #57. Adds the Post Transaction endpoint, and completes the Transactions endpoint group.
For this endpoint, a new request type
PostRequesthas been created, in addition toRequest. We could discuss a naming convention, and perhaps changeRequesttoGetRequest.Note: this PR includes some testnet value updates. During the updating of these values, it became clear some response values in the Trades endpoint are optional. These fields have been updated in the response struct.
📝 Links to relevant issues/docs
https://developers.stellar.org/docs/data/horizon/api-reference/submit-a-transaction
🤔 Checklist before submitting