Use rs-stellar-xdr for serialization/deserialization #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
Currentely, the XDR deserialization and models are by our own custom implementation, which did not work properly yet.
🆕 What is the new behavior (if this is a feature change)?
RS-Stellar-XDR seems to provide the XDR deserialization features we need for our API. I've included this in our project and ensured it's deserialization features with unit tests. This can also be used as a reference.
💥 Does this PR introduce a breaking change?
Yes
🐛 Recommendations for testing
Run cargo test to see whether deserialization using the rs-stellar-xdr crate works.
📝 Links to relevant issues/docs
I think we should not try and reinvent the wheel here. rs-stellar-xdr looks promising. It has some great team members like Graydon Hoare (known for serde), and undergoes active development.
🤔 Checklist before submitting