Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWI-1695: Adding a missing environment variable #80

Merged
merged 10 commits into from
Oct 24, 2023
16 changes: 7 additions & 9 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
MANTECA_BASE_URL: ${{ secrets.MANTECA_BASE_URL }}
MANTECA_IDLE_NUMBER: ${{ secrets.MANTECA_IDLE_NUMBER }}
OPERATING_SYSTEM: ubuntu-latest
CSHARP_VERSION: 7.0.x
DOTNET_VERSION: 7.0.x

jobs:
deploy_pre_release:
Expand All @@ -37,9 +37,8 @@ jobs:

- name: Check Release Tag Format
run: |
re='^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(-(beta|alpha|rc))(\.[0-9]+)?$'
if ! [[ $RELEASE_VERSION =~ $re ]]; then
echo "Tag does not match expected regex pattern for beta releases ($re)"
if ! [[ $RELEASE_VERSION =~ ^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-(beta|alpha|rc))(\.[0-9][0-9]*)?$ ]]; then
echo 'Tag does not match expected regex pattern for beta releases (^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-(beta|alpha|rc))(\.[0-9][0-9]*)?$)'
ckoegel marked this conversation as resolved.
Show resolved Hide resolved
echo $RELEASE_VERSION
echo 'Please update your tag to match the expected regex pattern'
exit 1
Expand All @@ -55,7 +54,7 @@ jobs:
with:
dotnet-version: '7.0.x'

- name: Run integration tests
- name: Run functional tests
run: dotnet test $BW_PROJECT_TEST_NAME

- name: Pack NuGet package
Expand Down Expand Up @@ -88,9 +87,8 @@ jobs:

- name: Check Release Tag Format
run: |
re='^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)$'
if ! [[ $RELEASE_VERSION =~ $re ]]; then
echo "Tag does not match expected regex pattern for releases ($re)"
if ! [[ $RELEASE_VERSION =~ ^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)$ ]]; then
echo 'Tag does not match expected regex pattern for releases (^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)$)'
echo $RELEASE_VERSION
echo 'Please update your tag to match the expected regex pattern'
exit 1
Expand All @@ -104,7 +102,7 @@ jobs:
with:
dotnet-version: '7.0.x'

- name: Run integration tests
- name: Run functional tests
run: dotnet test $BW_PROJECT_TEST_NAME

- name: Pack NuGet package
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/test-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ jobs:
- name: Run functional tests
env:
OPERATING_SYSTEM: ${{ matrix.os }}
CSHARP_VERSION: ${{ matrix.dotnet }}
# Required for multiple target frameworks in the StandardTests project.
DOTNET: ${{ matrix.dotnet }}
DOTNET_VERSION: ${{ matrix.dotnet }}
run: dotnet test src/Bandwidth.Standard.Test

test_feature:
Expand All @@ -67,9 +65,7 @@ jobs:
- name: Run functional tests
env:
OPERATING_SYSTEM: ${{ matrix.os }}
CSHARP_VERSION: ${{ matrix.dotnet }}
# Required for multiple target frameworks in the StandardTests project.
DOTNET: ${{ matrix.dotnet }}
DOTNET_VERSION: ${{ matrix.dotnet }}
run: dotnet test src/Bandwidth.Standard.Test

notify_for_failures:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/test-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,5 @@ jobs:
- name: Run functional tests
env:
OPERATING_SYSTEM: ${{ matrix.os }}
CSHARP_VERSION: ${{ matrix.dotnet }}
# Required for multiple target frameworks in the StandardTests project.
DOTNET: ${{ matrix.dotnet }}
DOTNET_VERSION: ${{ matrix.dotnet }}
run: dotnet test src/Bandwidth.Standard.Test
4 changes: 2 additions & 2 deletions src/Bandwidth.Standard.Test/Bandwidth.Standard.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<PropertyGroup>
<AssemblyName>Bandwidth.Standard.Test</AssemblyName>
<RootNamespace>Bandwidth.Standard.Test</RootNamespace>
<TargetFramework Condition="'$(DOTNET)' == '6.0.x' Or '$(DOTNET)' == ''">net6.0</TargetFramework>
<TargetFramework Condition="'$(DOTNET)' == '7.0.x'">net7.0</TargetFramework>
<TargetFramework Condition="'$(DOTNET_VERSION)' == '6.0.x' Or '$(DOTNET_VERSION)' == ''">net6.0</TargetFramework>
<TargetFramework Condition="'$(DOTNET_VERSION)' == '7.0.x'">net7.0</TargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public Tuple<string, string> CreateConferenceTest()
var jsonBody = JsonSerializer.Serialize(new
{
os = Environment.GetEnvironmentVariable("OPERATING_SYSTEM"),
language = "csharp" + Environment.GetEnvironmentVariable("CSHARP_VERSION"),
language = "csharp" + Environment.GetEnvironmentVariable("DOTNET_VERSION"),
type = "CONFERENCE"
});
var options = new RequestOptions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public Tuple<string, string> CreateAndValidateCall()
var jsonBody = JsonSerializer.Serialize(new
{
os = Environment.GetEnvironmentVariable("OPERATING_SYSTEM"),
language = "csharp" + Environment.GetEnvironmentVariable("CSHARP_VERSION"),
language = "csharp" + Environment.GetEnvironmentVariable("DOTNET_VERSION"),
type = "CALL"
});
var options = new RequestOptions
Expand Down
Loading