Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[공통] 레이아웃 분리 #273

Merged
merged 14 commits into from
Mar 10, 2024
Merged

[공통] 레이아웃 분리 #273

merged 14 commits into from
Mar 10, 2024

Conversation

kimeodml
Copy link
Contributor

@kimeodml kimeodml commented Mar 6, 2024

[#272] request

총 세 개의 레이아웃이 존재해 피그마 기준으로 분류 완료했습니다.

  • TopDefaultLayout, TopBottomLayout, SideBottomLayout으로 분류했습니다.

추가적으로 마커 클러스터링 수정 완료했습니다!!!! 이제 마커 클러스터링 지워집니다😭

  • 추측이지만 js 파일을 import하는 과정에서 eslint 오류가 많이 발생했었는데 몇가지는 제가 직접 수정했고, 몇가지는 상단에 주석처리로 무시하였습니다. 이 과정에서 제가 직접 수정했던 부분에서 마커가 지워지는 기능에 문제가 생겼던 것 같습니다.

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • There are no warning message when you run yarn lint
  • Docs updated for breaking changes

Screenshot

-Chrome2024-03-0618-27-01

Precautions (main files for this PR ...)

Closes #272

@kimeodml kimeodml changed the title Feature/#272 [공통] 레이아웃 분리 Mar 6, 2024
Comment on lines +244 to +247
가입된 아이디는
{' '}
{user.id}
입니다
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마이너))

Suggested change
가입된 아이디는
{' '}
{user.id}
입니다
{`가입된 아이디는 ${user.id} 입니다`}

Copy link
Member

@ChoiWonBeen ChoiWonBeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@kimeodml kimeodml merged commit b1bb6f2 into develop Mar 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[공통] 레이아웃 분리
2 participants