[Search] 카테고리 선택 버튼 구현 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghaesung79
requested review from
chaeseungyun,
hyejun0228,
kimeodml,
LUNA-KK,
HAEROOL and
hanagertrudeKim
as code owners
| isCafe: boolean; | ||
| } | ||
|
|
||
| export default function CategorySelect({ className, isCafe, onClick }: Props) { |
There was a problem hiding this comment.
통상적으로 두개의 상태로 관리되는 ui 는 토글이라는 말을 더 많이 쓰는것같아요
Suggested change
| export default function CategorySelect({ className, isCafe, onClick }: Props) { | |
| export default function CategoryToggle({ className, isCafe, onClick }: Props) { |
There was a problem hiding this comment.
저도 이름을 정하는 데 고민이 많이 되더라구요. 원래 CategoryToggleButton이나 CategoryToggle로 정하고 만들고 있는데 읽고 생각할 때 어감이 좀 이상했어요. 그리고 on/off의 상태가 아니기 때문에 toggle이 무조건 맞다는 생각이 안 들더라구요. 이건 다른 분들한테도 물어보고 싶어요.
There was a problem hiding this comment.
토글은 a <=> !a 의 느낌이 강한데
카페와 음식점이라는 서로 다른 값을 선택하는 느낌이라 select도 좋은 것 같아요
Comment on lines
-26
to
+27
| const { location, keyword } = params; | ||
| const url = `/shops?keyword=${keyword}`; | ||
| const { keyword, category, location } = params; | ||
| const url = `/shops?keyword=${keyword}?category=${category}`; |
hanagertrudeKim
approved these changes
Feb 27, 2024
chaeseungyun
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#248] request
shops를 가져오는 api에 category를 추가했습니다.
하지만 개발 환경에서 불러오는 정보가 정해져 있어서 테스트할 방법을 모르겠습니다...
Please check if the PR fulfills these requirements
developbranch, not themainbranchyarn lintScreenshot
Precautions (main files for this PR ...)