[Map] 마커 수정 및 기능 추가 #268
Merged
[Map] 마커 수정 및 기능 추가 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimeodml
requested review from
chaeseungyun,
hyejun0228,
LUNA-KK,
HAEROOL,
hanagertrudeKim and
junghaesung79
as code owners
junghaesung79
approved these changes
Feb 27, 2024
Comment on lines
+21
to
+26
| interface SideNavigationProps { | ||
| visible: boolean; | ||
| toggle: () => void; | ||
| setVisible: (state: boolean) => void; | ||
| } | ||
|
|
There was a problem hiding this comment.
visible을 프로퍼티로 전달하는 것으로 바꾸셨군요! 깔끔해진 것 같아요!
hanagertrudeKim
approved these changes
Feb 27, 2024
Comment on lines
+18
to
+25
| {!isMobile && <SideNavigation visible={visible} toggle={toggle} setVisible={setVisible} />} | ||
| <div | ||
| className={cn({ | ||
| [styles['home-container']]: true, | ||
| [styles['home-container--invisible']]: location.pathname !== '/', | ||
| })} | ||
| > | ||
| <Home visible={visible} /> |
There was a problem hiding this comment.
사이드바와 홈의 visible 여부가 한 상태로 관리되는 이유가 있나요???
There was a problem hiding this comment.
컴포넌트가 다르면 패널이 열려도 지도가 우측으로 이동되지 않기 때문에 공유되도록 레이아웃에서 useBoolean을 선언했습니다. 혹시 다른 방법이 있을까요?
react-naver-maps 패키지를 활용해서 마커 클러스터링을 구현 했는데 없어도 구현이 가능해서 제거하면서 같이 지워진 캐시들인 것 같습니다 |
|
같은 라우터에 있어서인지 음식점 상세쪽의 지도가 나타나지 않더라고요. DefaultLayout이 두 종류(Top, Bottom/Side, Bottom)로 되어있어서 레이아웃 분리를 통해 서로 다른 라우터에 있도록 변경하겠습니다. 아마 그렇게 진행하면 오류가 해결될 것 같아요! 이 부분은 이슈 새로 파서 진행하겠습니다. @hanagertrudeKim |
hanagertrudeKim
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#266 ] request
Please check if the PR fulfills these requirements
developbranch, not themainbranchyarn lintScreenshot
Precautions (main files for this PR ...)
Closes #266