-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
117 Emodule mapping script #118
Conversation
The mapping script from Ilias has been now replaced with a mapping script like the one used for SimpleOntology. It is not finished yet! Edit: Or this one might be even better https://docs.python.org/3/library/uuid.html |
Changes at the emodule-metadata-extraction-script: There is still more metadata extracted than needed for mapping (f.e. the units and information about the software), but I decided to not delete that code for now, in case we want to add placeholders for them in the ontology. (I could also comment them out, for now they will be in the generated yaml-file). I marked these useless keys with a comment. The transducer-value ([1,2,3]) needs to be fixed, it seems like a list can't be passed easily to the mapping script. On that point, also the names of the placeholders for transducer column and compression column inside the ontology might need to be changed, since they don't fit the corresponding individuals and the mapping script can't work with that. |
Could you check the tests, they are not working. |
@soudehMasoudian The mapping test is outdated, because it depends on Ilias old mapping script. Could you please look into this? |
I think this script is almost finshed now. Tests are said to fail because the tests don't fit the script but a very old version of it. See #134 for this. |
…4_08_05 Rezeptur_MI.json
Pull request for issue #117 .