Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

117 Emodule mapping script #118

Closed
wants to merge 184 commits into from
Closed

117 Emodule mapping script #118

wants to merge 184 commits into from

Conversation

alFrie
Copy link
Collaborator

@alFrie alFrie commented Feb 9, 2023

Pull request for issue #117 .

@alFrie alFrie linked an issue Feb 9, 2023 that may be closed by this pull request
5 tasks
@joergfunger joergfunger mentioned this pull request Feb 9, 2023
5 tasks
@alFrie
Copy link
Collaborator Author

alFrie commented Feb 13, 2023

The mapping script from Ilias has been now replaced with a mapping script like the one used for SimpleOntology. It is not finished yet!
Here we don't append the name of the specimen (as stated in the metadata-yaml) to the individuals, but instead we want to create an unique ID within the script and append it. One possible way of doing this, which got mentioned during the Hackathon, is this one: https://pypi.org/project/python-datauri/

Edit: Or this one might be even better https://docs.python.org/3/library/uuid.html

@alFrie
Copy link
Collaborator Author

alFrie commented Feb 14, 2023

Changes at the emodule-metadata-extraction-script:
I have changed the names of the keys for the metadata dictionary to fit the placeholders, so that the mapping script can work.
Some information has been hardcoded: the specimen age, the lab location and the transducer/compression column.

There is still more metadata extracted than needed for mapping (f.e. the units and information about the software), but I decided to not delete that code for now, in case we want to add placeholders for them in the ontology. (I could also comment them out, for now they will be in the generated yaml-file). I marked these useless keys with a comment.

The transducer-value ([1,2,3]) needs to be fixed, it seems like a list can't be passed easily to the mapping script. On that point, also the names of the placeholders for transducer column and compression column inside the ontology might need to be changed, since they don't fit the corresponding individuals and the mapping script can't work with that.

@alFrie alFrie self-assigned this Feb 14, 2023
@joergfunger
Copy link
Member

Could you check the tests, they are not working.

@alFrie
Copy link
Collaborator Author

alFrie commented Feb 16, 2023

Could you check the tests, they are not working.

@soudehMasoudian The mapping test is outdated, because it depends on Ilias old mapping script. Could you please look into this?

@alFrie
Copy link
Collaborator Author

alFrie commented Feb 28, 2023

I noticed that my script fails to append the unique ID after a lot of underscores, like here. I will fix this now.

image

Edit: Done.

@alFrie
Copy link
Collaborator Author

alFrie commented Mar 9, 2023

I think this script is almost finshed now. Tests are said to fail because the tests don't fit the script but a very old version of it. See #134 for this.

@alFrie alFrie marked this pull request as ready for review March 9, 2023 10:50
@mattheokru mattheokru closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-Module Mapping Script
6 participants