Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more rootkey logging, allow SignatureToJsonValue to fail #676

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add more rootkey logging, allow SignatureToJsonValue to fail #676

wants to merge 1 commit into from

Conversation

jw-msft
Copy link
Contributor

@jw-msft jw-msft commented Dec 7, 2024

  • Add more logging in jws and rootkey utils
  • Correct ADUC_RootKeyPackageUtils_SignatureToJsonValue so it will return fail if it encounters one

@jw-msft jw-msft requested a review from nihemstr December 7, 2024 00:12
@jw-msft jw-msft mentioned this pull request Dec 7, 2024
Open
nihemstr
nihemstr approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@nihemstr nihemstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with single comment for fall through.

src/utils/root_key_utils/src/root_key_util.c
case ADUC_RootKey_KeyType_INVALID:
break;

case ADUC_RootKey_KeyType_INVALID: // fallthrough
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallthroughs can be hard to maintain if someone doesnt pay attention to them when adding new cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihemstr nihemstr nihemstr approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jw-msft @nihemstr