feat: Add delete override option in the API #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
add-delete-override
branch
from
939029e to
66d4de7
Compare
ryanzhang-oss
changed the title
ryanzhang-oss
force-pushed
the
add-delete-override
branch
from
66d4de7 to
01acd89
Compare
zhiying-lin
reviewed
Nov 25, 2024
circy9
reviewed
Nov 25, 2024
| // +kubebuilder:validation:Enum=JSONPatch;Delete | ||
| // +kubebuilder:default:JSONPatch | ||
| // +optional | ||
| OverrideType OverrideType `json:"overrideType,omitempty"` |
There was a problem hiding this comment.
Better to move this to be after ClusterSelector.
Why?
- Specify the target and then specify the desired action upon the target.
- OverrideType and JSONPatchOverrrides are used to describe the action. They should be together.
ryanzhang-oss
force-pushed
the
add-delete-override
branch
from
09d233a to
571b8e4
Compare
circy9
approved these changes
Nov 25, 2024
zhiying-lin
reviewed
Nov 26, 2024
| // +kubebuilder:validation:Enum=JSONPatch;Delete | ||
| // +kubebuilder:default:JSONPatch | ||
| // +optional | ||
| OverrideType OverrideType `json:"overrideType,omitempty"` |
There was a problem hiding this comment.
Suggested change
| OverrideType OverrideType `json:"overrideType,omitempty"` | |
| Type OverrideType `json:"type,omitempty"` |
| } | ||
|
|
||
| // OverrideType defines the type of Override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer