feat: copy drift/diff details from work status to binding status #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelawyu
reviewed
Nov 18, 2024
| // or the failed placements are changed. | ||
| if condition.EqualCondition(oldAppliedCondition, newAppliedCondition) && condition.EqualCondition(oldAvailableCondition, newAvailableCondition) { | ||
| // or the failed/diffed/drifted placements are changed. | ||
| if !comparePlacements(oldWork, newWork) && condition.EqualCondition(oldAppliedCondition, newAppliedCondition) && condition.EqualCondition(oldAvailableCondition, newAvailableCondition) { |
There was a problem hiding this comment.
Hi Britania! Glad that you caught the error in this flow; but the current setup kind of defeats the purpose of this check, which was meant to reduce the overhead for doing comparisons.
britaniar
force-pushed
the
workstatus
branch
2 times, most recently
from
151221c to
7f1f20f
Compare
britaniar
force-pushed
the
workstatus
branch
from
7f1f20f to
f680d1c
Compare
michaelawyu
reviewed
Nov 26, 2024
britaniar
force-pushed
the
workstatus
branch
from
a3d7658 to
19110a0
Compare
Comment on lines
+1155
to
1173
| } else { | ||
| oldResourceSnapshot := oldWork.Labels[fleetv1beta1.ParentResourceSnapshotIndexLabel] | ||
| newResourceSnapshot := newWork.Labels[fleetv1beta1.ParentResourceSnapshotIndexLabel] | ||
| if oldResourceSnapshot == "" || newResourceSnapshot == "" { | ||
| klog.ErrorS(controller.NewUnexpectedBehaviorError(errors.New("found an invalid work without parent-resource-snapshot-index")), | ||
| "Could not find the parent resource snapshot index label", "oldWork", klog.KObj(oldWork), "oldResourceSnapshotLabelValue", oldResourceSnapshot, | ||
| "newWork", klog.KObj(newWork), "newResourceSnapshotLabelValue", newResourceSnapshot) | ||
| return | ||
| } | ||
| // There is an edge case that, the work spec is the same but from different resourceSnapshots. | ||
| // WorkGenerator will update the work because of the label changes, but the generation is the same. | ||
| // When the normal update happens, the controller will set the applied condition as false and wait | ||
| // until the work condition has been changed. | ||
| // In this edge case, we need to requeue the binding to update the binding status. | ||
| if oldResourceSnapshot == newResourceSnapshot { | ||
| klog.V(2).InfoS("The work applied or available condition stayed as true, no need to reconcile", "oldWork", klog.KObj(oldWork), "newWork", klog.KObj(newWork)) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
I wonder if we still need this?
There was a problem hiding this comment.
Yes. I am only comparing the status, so it is still necessary to have these checks that we implemented recently.
ryanzhang-oss
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
copied work status drift/diff details to binding status
unit tests for new functions created
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer