Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve tutorial #947

Merged
merged 23 commits into from
Nov 8, 2024
Merged

docs: Improve tutorial #947

merged 23 commits into from
Nov 8, 2024

Conversation

jamyct
Copy link
Contributor

@jamyct jamyct commented Nov 8, 2024

Description of your changes

Improve tutorial for Migration with Override DR

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@jamyct jamyct marked this pull request as draft November 8, 2024 01:22
@britaniar britaniar changed the title Improve tutorial docs: Improve migration with override tutorial Nov 8, 2024
@jamyct jamyct changed the title docs: Improve migration with override tutorial docs: Improve tutorial Nov 8, 2024
Copy link
Contributor

@britaniar britaniar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add links within the tutorial to the correlated files, otherwise the user will not know they exist for this purpose.

docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
@jamyct jamyct marked this pull request as ready for review November 8, 2024 02:12
docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
Copy link
Contributor

@britaniar britaniar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please similarly link the cluster resource override yaml as well.

docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
docs/tutorials/MigrationWithOverrideDR.md Outdated Show resolved Hide resolved
docs/tutorials/testfiles/crp-availability.yaml Outdated Show resolved Hide resolved
@britaniar britaniar merged commit 3cb2de9 into Azure:main Nov 8, 2024
6 checks passed
@jamyct jamyct deleted the improve-tutorial branch November 8, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants