Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cluster update run api definition #931

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

ryanzhang-oss
Copy link
Contributor

Description of your changes

Add clusterupdaterun API

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the added comments, things LGTM ;)

apis/placement/v1alpha1/stagedupdate_types.go Show resolved Hide resolved
apis/placement/v1alpha1/stagedupdate_types.go Outdated Show resolved Hide resolved
apis/placement/v1alpha1/stagedupdate_types.go Outdated Show resolved Hide resolved
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@ryanzhang-oss ryanzhang-oss merged commit f381cd2 into Azure:main Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants