Juntuchen/alpha4 ops

.github/CODEOWNERS

@@ -85,7 +85,7 @@
 
 # PRLabel: %Communication - Email
 # ServiceLabel: %Communication - Email
-/sdk/communication/communication-email/ @yogeshmo
+/sdk/communication/communication-email/ @yogeshmo @natekimball-msft @kagbakpem
 
 # PRLabel: %Communication - Job Router
 # ServiceLabel: %Communication - Job Router

.scripts/automation_init.sh

@@ -1,4 +1,4 @@
 #!/usr/bin/env bash
-npm install -g @azure-tools/typespec-client-generator-cli
+npm install -g @azure-tools/typespec-client-generator-cli@0.14.1
 npm install -g @microsoft/[email protected]
 npm install -g @azure-tools/js-sdk-release-tools

common/tools/dev-tool/package.json

@@ -54,7 +54,6 @@
     "@rollup/plugin-node-resolve": "^15.2.3",
     "chalk": "^4.1.1",
     "concurrently": "^8.2.2",
-    "decompress": "^4.2.1",
     "dotenv": "^16.0.0",
     "env-paths": "^2.2.1",
     "express": "^4.19.2",
@@ -74,12 +73,13 @@
     "tsx": "^4.0.0",
     "typescript": "~5.6.2",
     "yaml": "^2.3.4",
-    "@arethetypeswrong/cli": "^0.17.0"
+    "@arethetypeswrong/cli": "^0.17.0",
+    "tar": "^7.4.3",
+    "unzipper": "~0.12.3"
   },
   "devDependencies": {
     "@eslint/js": "^9.9.0",
     "@types/archiver": "^6.0.2",
-    "@types/decompress": "^4.2.7",
     "@types/express": "^4.17.21",
     "@types/express-serve-static-core": "^4.19.0",
     "@types/fs-extra": "^11.0.4",
@@ -95,6 +95,7 @@
     "rimraf": "^5.0.5",
     "typescript-eslint": "~8.16.0",
     "uglify-js": "^3.4.9",
-    "vitest": "^2.0.5"
+    "vitest": "^2.0.5",
+    "@types/unzipper": "~0.10.10"
   }
 }

common/tools/dev-tool/src/commands/admin/create-migration.ts

@@ -72,7 +72,6 @@ export default leafCommand(commandInfo, async (options) => {
   let id = options.name ?? (await prompt("Migration Id: "));
   let migrationFile = path.resolve(__dirname, "..", "..", "migrations", ...id.split("/")) + ".ts";
   // Need to check that the id is a simple identifier that only contains alphanumeric characters, underscores, dashes, and slashes.
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     let failed = false;
     if (!/^[a-zA-Z0-9_\-/]+$/.test(id)) {

common/tools/dev-tool/src/commands/admin/migrate-package.ts

@@ -100,7 +100,7 @@ export default leafCommand(commandInfo, async ({ "package-name": packageName, br
 
 async function prepareFiles(projectFolder: string, options: { browser: boolean }): Promise<void> {
   log.info("Migrating package.json, tsconfig.json, and api-extractor.json");
-  await upgradePackageJson(projectFolder, resolve(projectFolder, "package.json"));
+  await upgradePackageJson(projectFolder, resolve(projectFolder, "package.json"), options);
   await upgradeTypeScriptConfig(resolve(projectFolder, "tsconfig.json"));
   await fixApiExtractorConfig(resolve(projectFolder, "api-extractor.json"));
   await commitChanges(projectFolder, "Update package.json, tsconfig.json, and api-extractor.json");
@@ -110,6 +110,7 @@ async function prepareFiles(projectFolder: string, options: { browser: boolean }
     await writeBrowserTestConfig(projectFolder);
     await writeFile(resolve(projectFolder, "vitest.browser.config.ts"), VITEST_BROWSER_CONFIG);
   }
+  await writeFile(resolve(projectFolder, "vitest.esm.config.ts"), VITEST_ESM_CONFIG);
   await writeFile(resolve(projectFolder, "vitest.config.ts"), VITEST_CONFIG);
   await commitChanges(projectFolder, "Update test config");
 
@@ -121,13 +122,24 @@ async function prepareFiles(projectFolder: string, options: { browser: boolean }
 async function applyCodemods(projectFolder: string): Promise<void> {
   const project = new Project({ tsConfigFilePath: resolve(projectFolder, "tsconfig.json") });
 
+  const skipPatterns = [/^vitest.*\.config\.ts$/];
+
   // Apply the codemods, one at a time, to all source files in the project.
   // Commit the changes after each codemod is applied for ease of reviewing.
   // For more information on the codemods and how to contribute, see the `codemods` directory.
   for (const mod of codemods) {
     log.info(`Applying codemod: ${mod.name}`);
     for (const sourceFile of project.getSourceFiles()) {
+      // Skip config files
+      if (skipPatterns.some((pattern) => pattern.test(sourceFile.getBaseName()))) {
+        continue;
+      }
+
       mod(sourceFile);
+
+      // Clean up source file after applying the codemod
+      sourceFile.fixUnusedIdentifiers();
+
       await sourceFile.save();
     }
     await commitChanges(projectFolder, `Apply codemod: "${mod.name}"`);
@@ -138,17 +150,9 @@ const VITEST_CONFIG = `
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-import { defineConfig, mergeConfig } from "vitest/config";
 import viteConfig from "../../../vitest.shared.config.ts";
 
-export default mergeConfig(
-  viteConfig,
-  defineConfig({
-    test: {
-      include: ["test/**/*.spec.ts"],
-    },
-  }),
-);
+export default viteConfig;
 `;
 
 const VITEST_BROWSER_CONFIG = `
@@ -170,6 +174,20 @@ export default mergeConfig(
 );
 `;
 
+const VITEST_ESM_CONFIG = `
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { mergeConfig } from "vitest/config";
+import vitestConfig from "./vitest.config.ts";
+import vitestEsmConfig from "../../../vitest.esm.shared.config.ts";
+
+export default mergeConfig(
+  vitestConfig,
+  vitestEsmConfig
+);
+`;
+
 async function writeBrowserTestConfig(packageFolder: string): Promise<void> {
   const testConfig = {
     extends: "./.tshy/build.json",
@@ -217,30 +235,55 @@ async function cleanupFiles(projectFolder: string): Promise<void> {
 }
 
 async function upgradeTypeScriptConfig(tsconfigPath: string): Promise<void> {
-  const tsConfig = JSON.parse(await readFile(tsconfigPath, "utf-8"));
-
-  // Set module resolution
-  tsConfig.compilerOptions.module = "NodeNext";
-  tsConfig.compilerOptions.moduleResolution = "NodeNext";
-  tsConfig.compilerOptions.rootDir = ".";
-  tsConfig.include = [
-    "src/**/*.ts",
-    "src/**/*.mts",
-    "src/**/*.cts",
-    "samples-dev/**/*.ts", // TODO: Check if samples-dev is needed
-    "test/**/*.ts",
-    "test/**/*.mts",
-    "test/**/*.cts",
-  ];
+  const packageJson = JSON.parse(
+    await readFile(resolve(dirname(tsconfigPath), "package.json"), "utf-8"),
+  );
 
-  // Remove old options
-  delete tsConfig.compilerOptions.outDir;
-  delete tsConfig.compilerOptions.declarationDir;
+  const tsConfig = {
+    references: [
+      {
+        path: "./tsconfig.src.json",
+      },
+      {
+        path: "./tsconfig.samples.json",
+      },
+      {
+        path: "./tsconfig.test.json",
+      },
+    ],
+  };
 
   await saveJson(tsconfigPath, tsConfig);
+
+  const tsSamplesConfig = {
+    extends: "../../../tsconfig.samples.base.json",
+    compilerOptions: {
+      paths: {
+        [`${packageJson.name}`]: ["./dist/esm"],
+      },
+    },
+  };
+
+  await saveJson(resolve(dirname(tsconfigPath), "tsconfig.samples.json"), tsSamplesConfig);
+
+  const tsConfigSrc = {
+    extends: "../../../tsconfig.lib.json",
+  };
+
+  await saveJson(resolve(dirname(tsconfigPath), "tsconfig.src.json"), tsConfigSrc);
+
+  const tsConfigTest = {
+    extends: ["./tsconfig.src.json", "../../../tsconfig.test.base.json"],
+  };
+
+  await saveJson(resolve(dirname(tsconfigPath), "tsconfig.test.json"), tsConfigTest);
 }
 
-async function upgradePackageJson(projectFolder: string, packageJsonPath: string): Promise<void> {
+async function upgradePackageJson(
+  projectFolder: string,
+  packageJsonPath: string,
+  options: { browser: boolean },
+): Promise<void> {
   const packageJson = JSON.parse(await readFile(packageJsonPath, "utf-8"));
 
   // Change the module type to ESM
@@ -250,37 +293,56 @@ async function upgradePackageJson(projectFolder: string, packageJsonPath: string
   removeLegacyPackages(packageJson);
 
   // Add the new packages
-  await addNewPackages(packageJson);
+  await addNewPackages(packageJson, options);
 
   // Sort the devDependencies
   sortPackage(packageJson);
 
   // Add tshy
-  addTypeScriptHybridizer(packageJson);
+  addTypeScriptHybridizer(packageJson, options);
 
   // Set files
   setFilesSection(packageJson);
 
   // Set scripts
-  setScriptsSection(packageJson.scripts);
+  setScriptsSection(packageJson.scripts, {
+    ...options,
+    isArm: packageJson.name.includes("@azure/arm-"),
+  });
 
   // Rename files and rewrite browser field
   await renameFieldFiles("browser", "browser", projectFolder, packageJson);
   await renameFieldFiles("react-native", "native", projectFolder, packageJson);
   packageJson.browser = "./dist/browser/index.js";
-  delete packageJson["react-native"];
+  packageJson["react-native"] = "./dist/react-native/index.js";
+
+  if (!options.browser) {
+    packageJson.browser = undefined;
+    packageJson["react-native"] = undefined;
+  }
 
   // Save the updated package.json
   await saveJson(packageJsonPath, packageJson);
 }
 
-function setScriptsSection(scripts: PackageJson["scripts"]): void {
-  scripts["build"] = "npm run clean && dev-tool run build-package && dev-tool run extract-api";
+function setScriptsSection(
+  scripts: PackageJson["scripts"],
+  options: { browser: boolean; isArm: boolean },
+): void {
+  scripts["build"] =
+    "npm run clean && dev-tool run build-package && dev-tool run vendored mkdirp ./review && dev-tool run extract-api";
+
+  if (options.browser) {
+    scripts["unit-test:browser"] =
+      "npm run clean && dev-tool run build-package && dev-tool run build-test && dev-tool run test:vitest --browser";
+  }
 
-  scripts["unit-test:browser"] =
-    "npm run clean && dev-tool run build-package && dev-tool run build-test && dev-tool run test:vitest --browser";
   scripts["unit-test:node"] = "dev-tool run test:vitest";
 
+  if (options.isArm) {
+    scripts["integration-test:node"] = "dev-tool run test:vitest --esm";
+  }
+
   for (const script of Object.keys(scripts)) {
     if (scripts[script].includes("tsc -p .")) {
       log.info(`Replacing usage of "tsc -p ." with "dev-tool run build-package" in ${script}`);
@@ -292,11 +354,15 @@ function setScriptsSection(scripts: PackageJson["scripts"]): void {
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function setFilesSection(packageJson: any): void {
   packageJson.files = ["dist/", "README.md", "LICENSE"];
+  if (packageJson.name.includes("@azure/arm-")) {
+    packageJson.files.push("review/", "CHANGELOG.md");
+  }
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-function addTypeScriptHybridizer(packageJson: any): void {
+function addTypeScriptHybridizer(packageJson: any, options: { browser: boolean }): void {
   packageJson["tshy"] = {
+    project: "./tsconfig.src.json",
     exports: {
       "./package.json": "./package.json",
       ".": "./src/index.ts",
@@ -306,6 +372,11 @@ function addTypeScriptHybridizer(packageJson: any): void {
     selfLink: false,
   };
 
+  // Remove the esmDialects for arm packages since we don't support ARM in the browser
+  if (!options.browser) {
+    delete packageJson["tshy"].esmDialects;
+  }
+
   // Check if there are subpath exports
   if (packageJson.exports) {
     for (const key of Object.keys(packageJson.exports)) {
@@ -318,15 +389,18 @@ function addTypeScriptHybridizer(packageJson: any): void {
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-async function addNewPackages(packageJson: any): Promise<void> {
-  const newPackages = {
+async function addNewPackages(packageJson: any, options: { browser: boolean }): Promise<void> {
+  const newPackages: Record<string, string | undefined> = {
     "@azure-tools/test-utils-vitest": "1.0.0",
-    "@vitest/browser": undefined,
     "@vitest/coverage-istanbul": undefined,
-    playwright: undefined,
     vitest: undefined,
   };
 
+  if (options.browser) {
+    newPackages["@vitest/browser"] = undefined;
+    newPackages["playwright"] = undefined;
+  }
+
   for (const [newPackage, desiredMinVersion] of Object.entries(newPackages)) {
     let latestVersion = desiredMinVersion;
     if (!latestVersion) {

common/tools/dev-tool/src/commands/admin/migrate-source.ts

@@ -81,18 +81,15 @@ export default leafCommand(commandInfo, async ({ "package-name": packageName })
 
   const projectFile = resolve(projectFolder, "tsconfig.json");
 
-  const projectFileContents = await readFile(projectFile, "utf-8");
-  const projectFileJSON = JSON.parse(projectFileContents);
-  const module = projectFileJSON.compilerOptions.module;
-  const moduleResolution = projectFileJSON.compilerOptions.moduleResolution;
-
-  if (module !== "NodeNext" || moduleResolution !== "NodeNext") {
-    log.info("Package does not use NodeNext module resolution. Skipping.");
-    return true;
-  }
+  const skipPatterns = [/^vitest.*\.config\.ts$/];
 
   const tsProject = new Project({ tsConfigFilePath: projectFile });
   for (const sourceFile of tsProject.getSourceFiles()) {
+    // Skip config files
+    if (skipPatterns.some((pattern) => pattern.test(sourceFile.getBaseName()))) {
+      continue;
+    }
+
     fixSourceFile(sourceFile);
     await sourceFile.save();
   }

common/tools/dev-tool/src/commands/migrate.ts

@@ -354,7 +354,7 @@ async function runMigrations(pending: Migration[], project: ProjectInfo): Promis
 async function onMigrationSuccess(
   project: ProjectInfo,
   migration: Migration,
-  quiet: boolean = false, // eslint-disable-line @typescript-eslint/no-inferrable-types
+  quiet: boolean = false,
 ): Promise<void> {
   await updateMigrationDate(project, migration);
 
@@ -372,7 +372,7 @@ async function onMigrationSuccess(
 async function onMigrationSkipped(
   project: ProjectInfo,
   migration: Migration,
-  quiet: boolean = false, // eslint-disable-line @typescript-eslint/no-inferrable-types
+  quiet: boolean = false,
 ): Promise<void> {
   await updateMigrationDate(project, migration);
 
@@ -451,10 +451,7 @@ function printMigrationSuspendedWarning(migration: Migration, status: MigrationS
  * @param project - the working project
  * @returns true on success, otherwise false
  */
-async function abortMigration(
-  project: ProjectInfo,
-  quiet: boolean = false, // eslint-disable-line @typescript-eslint/no-inferrable-types
-): Promise<boolean> {
+async function abortMigration(project: ProjectInfo, quiet: boolean = false): Promise<boolean> {
   const suspendedMigration = await validateSuspendedState(project);
   if (!suspendedMigration) return false;
 

common/tools/dev-tool/src/config/rollup.base.config.ts

@@ -168,7 +168,6 @@ export function sourcemaps() {
         debug("no map for file ", id);
         return { code, map: null };
       } catch (e) {
-        // eslint-disable-next-line no-inner-declarations
         function toString(error: unknown): string {
           return error instanceof Error ? (error.stack ?? error.toString()) : JSON.stringify(error);
         }