[Identity] Callback design for service connection support for Workload Identity Federation #29349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
bterlson,
xirzec,
jeremymeng,
mpodwysocki,
maorleger,
schaabs and
a team
as code owners
KarishmaGhiya
requested review from
joshfree,
billwert,
ahsonkhan and
scottaddie
|
What's the point of this over |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
billwert
reviewed
Apr 18, 2024
| @@ -84,15 +123,21 @@ export class WorkloadIdentityCredential implements TokenCredential { | |||
| */ | |||
| public async getToken( | |||
| scopes: string | string[], | |||
| options?: GetTokenOptions, | |||
| options?: GetTokenOptions | |||
There was a problem hiding this comment.
should there be a call to the callback in here somewhere? I don't see it being called anywhere yet, wondering what the end state you expect is.
5 tasks
|
Closing in favor of #29392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
An alternative design to this PR - #28628
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists