-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(designer): Update status pill spinner for only running actions #6249
base: main
Are you sure you want to change the base?
Conversation
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 suggestions.
Files not reviewed (3)
- Localize/lang/strings.json: Language not supported
- libs/designer-ui/src/lib/monitoring/statuspill/test/snapshots/statusicon.spec.tsx.snap: Language not supported
- libs/designer-ui/src/lib/monitoring/statuspill/test/statusicon.spec.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)
libs/designer-ui/src/lib/utils/utils.ts:335
- The word 'succeeeded' is misspelled. It should be 'succeeded'.
description: 'The status message to show succeeeded retries in monitoring view.. This refers to the succeeded status of a previous action.',
can we also desaturate the actions that haven't run yet and aren't running similar to how old designer does? I do think that provides a nice indicator that it hasn't been touched yet. |
Yep that sounds good, that will help to notice those aren't running yet |
This pull request includes multiple updates to the
StatusPill
component in thelibs/designer-ui
library. The most important changes include adding and modifying status messages in the localization file, updating theStatusPill
component to use Fluent UI'sTooltip
andSpinner
, and improving the test snapshots for theStatusIcon
component.StatusPill
component to use Fluent UI'sTooltip
instead ofTooltipHost
and ensured thestatus
prop is required.StatusIcon
component to use Fluent UI'sSpinner
instead of the deprecatedSpinner
from@fluentui/react
.StatusIcon
component to reflect the changes in the spinner and tooltip.Fixes #6201
Screenshots
Old implementation
New implementation