fix: clean up AB linting errors #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisonB319
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu and
junjiezhang1997
as code owners
Pull Request Test Coverage Report for Build 7053472052
💛 - Coveralls |
| ) | ||
|
|
||
| // CreateMockContainerService returns a mock container service for testing purposes. | ||
| func CreateMockContainerService(containerServiceName, orchestratorVersion string, masterCount, agentCount int, certs bool) *ContainerService { |
There was a problem hiding this comment.
we're sure we don't have any further usage of this?
There was a problem hiding this comment.
Yep there are no other calls to it in the repo
cameronmeissner
approved these changes
Nov 30, 2023
AlisonB319
commented
Nov 30, 2023
pkg/agent/bakerapi.go
Outdated
| @@ -23,6 +23,7 @@ func NewAgentBaker() (AgentBaker, error) { | |||
|
|
|||
| type agentBakerImpl struct{} | |||
|
|
|||
| //nolint:revive // ctx is not used, but may be in the future | |||
There was a problem hiding this comment.
directive //nolint:revive // ctx is not used, but may be in the future is unused for linter "revive" (nolintlint)
is a bug with golangci golangci/golangci-lint#3228
juan-lee
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: