Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default osDiskSizeGB based on OS Type #661

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Set default osDiskSizeGB based on OS Type #661

merged 4 commits into from
Nov 16, 2023

Conversation

iamvighnesh
Copy link
Contributor

PR Summary

Addressing the Issue #612, this PR sets the default for osDiskSizeGB for node pools based on OS Type:

  • for Linux, defaults to 30Gb
  • for Windows, defaults to 100Gb

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@pjlewisuk pjlewisuk added the needs-discussion An issue that needs a discussion with core maintainers to agree how to move forward label Oct 26, 2023
pjlewisuk
pjlewisuk approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge

@pjlewisuk pjlewisuk merged commit 4e88759 into main Nov 16, 2023
79 checks passed
@pjlewisuk pjlewisuk deleted the feat/default-os-disk-size-gb branch November 16, 2023 12:28
@pjlewisuk pjlewisuk mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjlewisuk pjlewisuk pjlewisuk approved these changes

Assignees
No one assigned
Labels
helper-ui needs-discussion An issue that needs a discussion with core maintainers to agree how to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamvighnesh @pjlewisuk