Make the build verb build for only one target
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I rarely find myself wanting to build for targets other than the device that I am currently testing with, and having to wait twice as long as necessary is annoying. I expect that CI workflows will still want to build for multiple targets, but that it should be a relatively small effort to call make twice since the developer only has to write that code once. A side effect of this change is that CI now only builds apps other than `hello_world` for one target. This could easily be fixed by adding a couple of lines in `CI.yml` but I think this is probably desirable since I expect the compilation success to be highly correlated.
I considered keeping the old behavior but with a new target named `all` because I received the feedback that it was surprising that: - the `all` target does not exist. - the `all` target is not the default. I'm choosing to not do that for now because what "all" means in the context of this project is a little bit unclear. Questions include: - should it build for all architectures - should it build the docs, which also is an artifact that the project provides.
…t_at_a_time * upstream/main: chore(deps): bump ghcr.io/devcontainers/features/common-utils (#38) chore(deps): bump log from 0.4.21 to 0.4.22 in the default group (#37) Add dev container (#36) Add link to acap-rs-app-template in `README.md` (#34) Document `python3-venv` dependency (#35) fix: Repair `Makefile` (#32)
apljungquist
added a commit
that referenced
this pull request
Jul 3, 2024
…more_specific * upstream/main: Adopt dev container as primary environment (#39) Make the `build` verb build for only one target (#31) chore(deps): bump ghcr.io/devcontainers/features/common-utils (#38) chore(deps): bump log from 0.4.21 to 0.4.22 in the default group (#37) Add dev container (#36) Add link to acap-rs-app-template in `README.md` (#34) Document `python3-venv` dependency (#35) fix: Repair `Makefile` (#32) fix(embedded_web_page): Put web page in `html/` (#30) Organize dependencies consistently (#29) chore(deps): bump glib-sys from 0.19.5 to 0.19.8 in the default group (#28) chore: Explain more make targets (#27)
apljungquist
added a commit
that referenced
this pull request
Jul 3, 2024
* upstream/main: Rename environment variables controlling the Makefile (#26) Adopt dev container as primary environment (#39) Make the `build` verb build for only one target (#31) chore(deps): bump ghcr.io/devcontainers/features/common-utils (#38) chore(deps): bump log from 0.4.21 to 0.4.22 in the default group (#37) Add dev container (#36) Add link to acap-rs-app-template in `README.md` (#34) Document `python3-venv` dependency (#35) fix: Repair `Makefile` (#32) fix(embedded_web_page): Put web page in `html/` (#30) Organize dependencies consistently (#29) chore(deps): bump glib-sys from 0.19.5 to 0.19.8 in the default group (#28) chore: Explain more make targets (#27) Add embedded web page example (#14)
apljungquist
added a commit
that referenced
this pull request
Jul 5, 2024
…_wrapper_and_exampl * upstream/main: Rename environment variables controlling the Makefile (#26) Adopt dev container as primary environment (#39) Make the `build` verb build for only one target (#31) chore(deps): bump ghcr.io/devcontainers/features/common-utils (#38) chore(deps): bump log from 0.4.21 to 0.4.22 in the default group (#37) Add dev container (#36) Add link to acap-rs-app-template in `README.md` (#34) Document `python3-venv` dependency (#35) fix: Repair `Makefile` (#32) fix(embedded_web_page): Put web page in `html/` (#30) Organize dependencies consistently (#29) chore(deps): bump glib-sys from 0.19.5 to 0.19.8 in the default group (#28) chore: Explain more make targets (#27) Add embedded web page example (#14) chore: Group and sort imports (#23) Demonstrate containerized builds (#17) Factor out `app_logging` modules to lib crate (#24)
apljungquist
added a commit
that referenced
this pull request
Jul 19, 2024
* upstream/main: Generate app `LICENSE` files (#44) Add acap-ssh-utils bin and lib crate (#19) Add cargo-acap-build tool (#25) Remove partially containerized workflow (#42) Improve acap-logging docs (#41) chore: Prepare logging library crate for publishing (#40) feat: Add metadata broker wrapper and example (#22) Rename environment variables controlling the Makefile (#26) Adopt dev container as primary environment (#39) Make the `build` verb build for only one target (#31) chore(deps): bump ghcr.io/devcontainers/features/common-utils (#38) chore(deps): bump log from 0.4.21 to 0.4.22 in the default group (#37) Add dev container (#36) Add link to acap-rs-app-template in `README.md` (#34) Document `python3-venv` dependency (#35) fix: Repair `Makefile` (#32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rarely find myself wanting to build for targets other than the device that I am currently testing with, and having to wait twice as long as necessary is annoying.
I expect that CI workflows will still want to build for multiple targets, but that it should be a relatively small effort to call make twice since the developer only has to write that code once.
A side effect of this change is that CI now only builds apps other than
hello_worldfor one target. This could easily be fixed by adding a couple of lines inCI.ymlbut I think this is probably desirable since I expect the compilation success to be highly correlated.