Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update card text color to maintain visibility in dark mode #385 #392

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

rizzit11
Copy link
Contributor

@rizzit11 rizzit11 commented Dec 1, 2024

Closes: #385

  • Title: fix: update card text color to maintain visibility in dark mode
  • Name: Rishit Patel (rizzit11)
  • Identify yourself: Open Source Contributor

Describe the add-ons or changes you've made 📃

  • Updated text color in E-Book and Video/Audio cards to remain black
  • Ensures text visibility in both light and dark modes
  • Modified [Home.jsx](/Volumes/Macintosh HD/Users/rishitpatel/Desktop/chanakya-niti/src/pages/Home.jsx) component to implement these changes

Type of change ☑️

  • Bug fix (non-breaking change which fixes an issue)

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-12-01 at 6 49 10 PM

Copy link

vercel bot commented Dec 1, 2024

@rizzit11 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Dec 1, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 5:07am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Avdhesh-Varshney Avdhesh-Varshney merged commit 9ed9621 into Avdhesh-Varshney:main Dec 4, 2024
5 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request level1 Beginner level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors Beginner Beginner level issues/pull requests labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors Beginner Beginner level issues/pull requests enhancement 🧑‍💻 New feature or request level1 Beginner level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: change text color
2 participants