Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved the feedback form #388

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Vivisteria11
Copy link

Closes: #377

  • Title : Feedback form enhancement
  • Name: Rakshita
  • Idenitfy yourself: GSSOC Contributor

The feedback form was very plain so I decided to enhance it by adding few more fields where I ask the users what they learnt from this ,what suggestions they have and rate their experience .

Type of change ☑️

Example how to mark a checkbox:-

  • My code follows the code style of this project.
    -->
  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • [ x] My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [x ] This PR does not contain plagiarized content.
  • [x ] I have performed a self-review of my own code.
  • [x ] I have commented my code, particularly wherever it was hard to understand.
  • [x ] My changes generate no new warnings.

Screenshots 📷

Note to reviewers 📄

I
Screenshot 2024-11-07 195757

Screenshot 2024-11-07 195808
Screenshot 2024-11-07 195816

Copy link

vercel bot commented Nov 7, 2024

Someone is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Nov 7, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.


const isValidEmail = (email) => {
// Simple email validation
return /^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/.test(email);

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'a' and containing many repetitions of 'a'.

const isValidEmail = (email) => {
// Simple email validation
return /^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/.test(email);

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'a@a' and containing many repetitions of 'a'.
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 10:16am

@Avdhesh-Varshney Avdhesh-Varshney merged commit 06a38b4 into Avdhesh-Varshney:main Nov 11, 2024
4 of 5 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request level3 Advanced level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors gssoc-ext gssoc extended 2024 labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request gssoc-ext gssoc extended 2024 level3 Advanced level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: improve the feedback form user interface
2 participants