Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Changes Made By Me #330

Closed
wants to merge 4 commits into from

Conversation

ankitsunil530
Copy link

@ankitsunil530 ankitsunil530 commented Oct 21, 2024

Closes:

  • Title : Some UI Changes
  • Name:
  • Idenitfy yourself:

Describe the add-ons or changes you've made 📃

  1. Make Static Navbar ,
    2) Hover Effect Implemented,
    3) Active Navbar when we on the page active nav,
    4) Add home button in navbar,
    5) Login page back ground change and enable google , twitter and GitHub icon button to navigate official site,
    6) Sign Up page back ground change and enable google , twitter and GitHub icon button to navigate official site,
    7) ChanakyaGpt page good style page stay in the center.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Navbar Home button added and Hover Effect
image
ActiveNav page seen
image
Github Twitter and Google icon active in login and sign Up page
image
ChanakyaGpt Page Looking good
image

Note to reviewers 📄

Copy link

vercel bot commented Oct 21, 2024

@ankitsunil530 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@ankitsunil530
Copy link
Author

Please check it and review it. as soon as possible.

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ❌ Failed (Inspect) Oct 24, 2024 10:42am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link your issue and review your own branch

src/css/ChanakyaGpt.css Show resolved Hide resolved
@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Oct 22, 2024
@ankitsunil530
Copy link
Author

I resolved all conficts. plaese review it and merge it.

Copy link
Author

@ankitsunil530 ankitsunil530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved all conflicts. #330 @Avdhesh-Varshney

@ankitsunil530
Copy link
Author

I resolved all conflicts. #330 @Avdhesh-Varshney

@ankitsunil530
Copy link
Author

Please check it and merge it.

@Avdhesh-Varshney
Copy link
Owner

I think you should again raise your pr because it is not deployed

@Avdhesh-Varshney Avdhesh-Varshney added wontfix ❌ This will not be worked on and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants