Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted_Images_to_WebP_for_Better_Optimization #312

Closed
wants to merge 2 commits into from
Closed

Converted_Images_to_WebP_for_Better_Optimization #312

wants to merge 2 commits into from

Conversation

smog-root
Copy link

Fixes #309

  • Converted all relevant images from formats like PNG and JPEG to WebP for better optimization and performance.
  • WebP offers better compression without significant quality loss, which helps in reducing file sizes and improves page load speed.

Changes:

  • Replaced existing image formats (JPEG, PNG) with WebP versions.
  • Updated image references in HTML files to reflect the new WebP file paths.
  • Verified that images render correctly in browsers that support WebP.

Testing:

  • Verified on multiple browsers (Chrome, Firefox, etc.) to ensure proper image rendering.
  • Ensured fallback mechanisms are in place for browsers that do not support WebP (if needed).

Note: Add gssoc-ext with level3, hacktoberfest-accepted labels! I think this PR deserves level3 label. Please add it i have worked hard to do this!

@Avdhesh-Varshney

@vercel Vercel
Copy link

vercel bot commented Oct 20, 2024

@smog-root is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 1:53pm

@smog-root
Copy link
Author

@Avdhesh-Varshney Merge it!!

@smog-root
Copy link
Author

Add labels and assign me! then merge !

Avdhesh-Varshney
Avdhesh-Varshney requested changes Oct 21, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't covert logo icon from png to webp. Just convert only high resolution images.

  • Review your deployment on your own

public/arthashastra.webp Outdated Show resolved Hide resolved
public/favicon.ico Outdated Show resolved Hide resolved
public/image.webp Outdated Show resolved Hide resolved
public/logo.webp Outdated Show resolved Hide resolved
@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Oct 21, 2024
@smog-root
Copy link
Author

Okay I will convert back logo form webp back to png! @Avdhesh-Varshney

@smog-root
Copy link
Author

@Avdhesh-Varshney Changed!!

@smog-root
Copy link
Author

@Avdhesh-Varshney merge it!!!

@smog-root
Copy link
Author

@Avdhesh-Varshney ??

Avdhesh-Varshney
Avdhesh-Varshney requested changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all are icons not the images

public/android-chrome-192x192.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

public/android-chrome-512x512.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

public/apple-touch-icon.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

public/favicon-16x16.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

public/favicon-32x32.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@smog-root smog-root closed this Oct 28, 2024
@smog-root
Copy link
Author

@Avdhesh-Varshney I will open another PR with changes!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney requested changes

Assignees

@smog-root smog-root

Labels
bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smog-root @Avdhesh-Varshney