Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflows: manually install svn #748

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

annemirasol
Copy link
Contributor

@annemirasol annemirasol commented Dec 16, 2024

Description

Recent workflow runs have been failing with bin/install-wp-tests.sh: line 141: svn: command not found, as the latest Ubuntu version no longer has svn pre-installed.

In this PR, we add a step to manually install subversion before running our tests.

How to test this PR

Verify Github workflows succeed.

Product impact

  • Added changelog entry (or does not apply): does not apply
  • Will this PR affect WooCommerce Subscriptions? no
  • Will this PR affect WooCommerce Payments? no
  • Added deprecated functions, hooks or classes to the spreadsheet

@annemirasol annemirasol force-pushed the dev/pin-gh-workflows-ubuntu branch from aea3649 to 908183e Compare December 16, 2024 15:35
@annemirasol annemirasol force-pushed the dev/pin-gh-workflows-ubuntu branch 2 times, most recently from cacbcc1 to 55a5868 Compare December 16, 2024 15:48
@annemirasol annemirasol force-pushed the dev/pin-gh-workflows-ubuntu branch from 55a5868 to 49e0639 Compare December 16, 2024 15:51
@annemirasol annemirasol changed the title Use Ubuntu 22.04 in GH workflow php-lint-test Github workflows: manually install svn Dec 16, 2024
@annemirasol annemirasol marked this pull request as ready for review December 16, 2024 15:56
@annemirasol annemirasol requested review from a team and mattallan and removed request for a team December 16, 2024 15:57
Copy link
Contributor

@mattallan mattallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @annemirasol for fixing this!

I'm going to approve this and merge this ahead of preparing the release today

@mattallan mattallan merged commit a9d0072 into trunk Dec 16, 2024
9 checks passed
@mattallan mattallan deleted the dev/pin-gh-workflows-ubuntu branch December 16, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants