-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prebuild for macos arm64, enable prebuilds to be run individually. #2451
base: prebuilds
Are you sure you want to change the base?
Conversation
increase to build on node 22. add runner macos-latest.
latest run with both PRs in place here: |
ahh... if I test without the container
in a separate test workflow, it does not fail? |
update node v from 22 to 'latest' Co-authored-by: Christian Clauss <[email protected]>
update node v from 22 to 'latest' Co-authored-by: Christian Clauss <[email protected]>
update github actions version Co-authored-by: Christian Clauss <[email protected]>
update github actions version Co-authored-by: Christian Clauss <[email protected]>
update node v from 22 to 'latest' Co-authored-by: Christian Clauss <[email protected]>
update node v from 22 to 'latest' Co-authored-by: Christian Clauss <[email protected]>
update github action script Co-authored-by: Christian Clauss <[email protected]>
@cclauss - I blindly added all your suggestions :). I don;t see a problem with using nodejs 'latest'. Let's hope you tested the gihub actions version updates (I have one repo which does not like a newer version). |
Co-authored-by: Christian Clauss <[email protected]>
@@ -34,6 +34,8 @@ | |||
'<!@(pkg-config pangocairo --libs)', | |||
'<!@(pkg-config freetype2 --libs)', | |||
'<!@(pkg-config librsvg-2.0 --libs)', | |||
'<!@(pkg-config libjpeg --libs)', | |||
'-L/opt/homebrew/lib', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running brew --prefix
or echo $HOMEBREW_PREFIX
will generate /opt/homebrew
on macOS ARM (Apple Silicon) CPUs but will generate /usr/local
on Intel Macs. https://docs.brew.sh/Installation
We should support both paths.
canvas_tag: ["v3.0.0-rc2"] # e.g. "v2.6.1" | ||
name: ${{ matrix.canvas_tag }}, Node.js ${{ matrix.node }}, Linux | ||
runs-on: ubuntu-latest | ||
if: contains(fromJson(inputs.os), 'ubuntu-latest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions docs on detecting the operating system: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#detecting-the-operating-system
- if: runner.os == 'Linux'
- if: runner.os == 'macOS'
- if: runner.os == 'Windows'
- if: runner.os != 'Windows'
To find the current version of any GitHub Action, you can: If you have error messages, I will help debug the issue. |
change name of macOSarm output to use actual runner.os and runner.arch Co-authored-by: Christian Clauss <[email protected]>
I merged #2354 instead since @zbjornson had reviewed it and it was first. OK to close? |
ee65e2b
to
02b26d1
Compare
Thanks for contributing!
'["ubuntu-latest", "windows-latest", "macos-13", "macos-latest"]'
.for best effect, combine with #2450 to result in smaller prebuilds
I note that 2 tests are failing during prebuild - on the original and on this branch (at least on linux - maybe a font issue). Maybe we should build the libraries from source, as test on main repo is not failing?
Also note #2354 - almost identical changes for actually building on arm64. But I have not included signing. I have never needed to sign a .node or a library before? - but then I don't have an M1/M2 mac.
@zbjornson @jamesbvaughan - pls. comment or combine the two PRs?