EMSUSD-1971 Make job context UI registeration be order-neutral #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Dec 18, 2024
pierrebai-adsk
commented
- Change the job context registration macro to be order-independent.
- Change unit test to verify that the macro are order-neutral by registering UI first.
- Change the job context registration macro to be order-independent. - Change unit test to verify that the macro are order-neutral by registering UI first.
pierrebai-adsk
added
enhancement
seando-adsk
reviewed
Dec 18, 2024
Comment on lines
+121
to
+131
| REGISTER_EXPORT_JOB_CONTEXT_FCT( | ||
| Curly, | ||
| "Curly's special", | ||
| "Test coverage of error handling part deux") | ||
| { | ||
| VtDictionary extraArgs; | ||
| // Incorrect type: | ||
| extraArgs[UsdMayaJobExportArgsTokens->apiSchema] = VtValue(std::string("testApi")); | ||
| return extraArgs; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't see any changes other than moving the macro. Is there a reason this macro moved below the other one?
There was a problem hiding this comment.
To test the fact that order no longer matters. Before my fix, this swap made the test fail for me locally as the UI callback was registered before the job context. Now it passes.
There was a problem hiding this comment.
Ah yes perfect. Thanks for thinking of that.
seando-adsk
approved these changes
Dec 18, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.