Spec Refactor #73
Merged
Spec Refactor #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Spec.build method is removed. Specs are now fully declarative and the DbType is responsible for implementation. * Add Spec.prefix method * Change Spec.seek nullOrder, Spec.orderBy direction and nullOrder to be database Default * Tests are improved and now shared between database specs insteads of duplicated. The increased coverage exposed some tangential issues which are also resolved in this MR (see below). Note: switched from munit assertEquals -> assert until fix for scalameta/munit#855 (comment) is released. Additional changes: * No longer need to handle null when using DbCodec.biMap, or implementing DbCodec.readSingle * When implementing DbCodec, new method readSingleOption must be defined * Support optional products in outer-join queries (see test OptionalProductTests) * Switched to latest scalafmt version to prevent OOM in OracleTests * Make Frag, Query, Update, Returning into regular classes * Frag.returningKeys method which uses ResultSet.getGeneratedKeys * Make MySq insertReturning throw, since we shouldn't define 2-query repository methods.
|
Merging now; please feel free to comment with any questions or suggestions, as this won't be released until v2.0.0 |
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes:
Closes
#63
#62
#34