Fix import of bookmarks. #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoding was not set correctly (to UTF-8) because the data were not read via QTextStream.
This crash sometimes occured when a BookmarkNode was being deleted.
This way some malformed XBEL files may be imported without worries (description would be ignored, title would be replaced with 'Unknown title' text), which increases compatibility at the cost of ignoring a part of the XBEL format standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding was not set correctly (to UTF-8) because the data were not read via QTextStream.
Fixes: https://code.google.com/p/arora/issues/detail?id=688
and possibly https://code.google.com/p/arora/issues/detail?id=944
The second part fixes a crash caused by (among others): https://code.google.com/p/arora/issues/detail?id=570
and the third part fixes the issue completely, although it might be a subject to discussion (reasons given in the commit message).