Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFC-27: Fix for tip forming when toolchange_temp is not zero #205

Merged
merged 9 commits into from
Dec 22, 2024

Conversation

jimmyjon711
Copy link
Contributor

@jimmyjon711 jimmyjon711 commented Dec 22, 2024

Major Changes in this PR

  • Fixed issue with klipper error out when toolchange_temp is not zero
  • Added two new macros, TEST_AFC_TIP_FORMING, SET_BUFFER_VELOCITY, RESET_AFC_MAPPING

Notes to Code Reviewers

How the changes in this PR are tested

Tested tip forming with new macro command
Tested SET_BUFFER_VELOCITY command
Tested RESET_AFC_MAPPING to make sure it reset and save to vars correctly

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@jimmyjon711 jimmyjon711 changed the title Fix for tip forming when toolchange_temp is not zero AFC-27: Fix for tip forming when toolchange_temp is not zero Dec 22, 2024
@jimmyjon711 jimmyjon711 marked this pull request as ready for review December 22, 2024 19:26
user-provided input. If no specific lane is provided, the function defaults to notifying the user that no lane has been selected. The function also includes
the option to calibrate the Bowden length for a particular lane, if specified.
Usage: ``CALIBRATE_AFC LANES=<lane> DISTANCE=<distance> TOLERANCE=<tolerance> BOWDEN=<lane>``
Example: `CALIBRATE_AFC LANE=leg1`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adjust this to CALIBRATE_AFC LANES=leg1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and changed from LANES to LANE in function

@MG-longshot MG-longshot merged commit c653f46 into ArmoredTurtle:main Dec 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants