-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AFC-27: Fix for tip forming when toolchange_temp is not zero #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minor error fixes - Added printouts when changing temp - Added setting temperature back to original value once tip forming is done
jimmyjon711
changed the title
Fix for tip forming when toolchange_temp is not zero
AFC-27: Fix for tip forming when toolchange_temp is not zero
Dec 22, 2024
ejsears
reviewed
Dec 22, 2024
user-provided input. If no specific lane is provided, the function defaults to notifying the user that no lane has been selected. The function also includes | ||
the option to calibrate the Bowden length for a particular lane, if specified. | ||
Usage: ``CALIBRATE_AFC LANES=<lane> DISTANCE=<distance> TOLERANCE=<tolerance> BOWDEN=<lane>`` | ||
Example: `CALIBRATE_AFC LANE=leg1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you adjust this to CALIBRATE_AFC LANES=leg1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated and changed from LANES to LANE in function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes in this PR
Notes to Code Reviewers
How the changes in this PR are tested
Tested tip forming with new macro command
Tested SET_BUFFER_VELOCITY command
Tested RESET_AFC_MAPPING to make sure it reset and save to vars correctly
PR Checklist: (Checked-off items are either done or do not apply to this PR)