Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with changing hub_loaded to loaded_to_hub in saved variables file #204

Merged
merged 10 commits into from
Dec 22, 2024

Conversation

jimmyjon711
Copy link
Contributor

@jimmyjon711 jimmyjon711 commented Dec 21, 2024

Major Changes in this PR

  • Fixing issue where hub_loaded is not loaded_to_hub in vars file, added a backwards combability check so users can upgrade without problem
  • Added an extruder object to lane so that extruder does not have to be looked up all the time
  • Fixed some more places where lane.name was being used as a key
  • Fixed error when trying to map lanes
  • Updated SET_SPOOLID to SET_SPOOL_ID so the documentation would match the actual macro name

Notes to Code Reviewers

How the changes in this PR are tested

  • Went through tool load and unload, tested mapping lanes.
  • Deleted vars files to make sure they were recreated correctly
  • Copied over old format of vars file to make sure configuration stayed the same between the old and new format

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@jimmyjon711 jimmyjon711 marked this pull request as ready for review December 21, 2024 22:15
@MG-longshot MG-longshot merged commit ac8e390 into ArmoredTurtle:DEV Dec 22, 2024
1 check passed
@jimmyjon711 jimmyjon711 deleted the hub_load_fixes branch December 22, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants